Skip to content

feat(linter/react): add version to ReactPluginSettings#17169

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-20-feat_linter_react_add_version_to_reactpluginsettings_
Dec 20, 2025
Merged

feat(linter/react): add version to ReactPluginSettings#17169
graphite-app[bot] merged 1 commit intomainfrom
c/12-20-feat_linter_react_add_version_to_reactpluginsettings_

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 20, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 20, 2025
Copy link
Contributor Author

camc314 commented Dec 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review December 20, 2025 12:57
Copilot AI review requested due to automatic review settings December 20, 2025 12:57
@camc314 camc314 force-pushed the c/12-20-feat_linter_react_add_version_to_reactpluginsettings_ branch from 21b5789 to 675de01 Compare December 20, 2025 12:57
@camc314 camc314 self-assigned this Dec 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a version field to the React plugin settings to support version-specific linting rules. The implementation includes a custom ReactVersion type that parses semver-style version strings (e.g., "18.2.0", "17.0") into structured major, minor, and patch components.

Key Changes:

  • Added version field (optional) to ReactPluginSettings in Rust
  • Implemented custom ReactVersion type with serde serialization/deserialization
  • Updated JSON schemas to reflect the new configuration option

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
npm/oxlint/configuration_schema.json Added version field to React settings schema and defined ReactVersion type structure
crates/oxc_linter/src/snapshots/schema_json.snap Updated schema snapshot to match the configuration schema changes
crates/oxc_linter/src/config/settings/react.rs Implemented ReactVersion struct with custom deserialization, serialization, and tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 camc314 marked this pull request as draft December 20, 2025 13:01
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 20, 2025

CodSpeed Performance Report

Merging #17169 will not alter performance

Comparing c/12-20-feat_linter_react_add_version_to_reactpluginsettings_ (6a42403) with main (ffc1674)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 force-pushed the c/12-20-feat_linter_react_add_version_to_reactpluginsettings_ branch from 675de01 to a45d639 Compare December 20, 2025 13:24
@camc314 camc314 marked this pull request as ready for review December 20, 2025 13:24
@camc314 camc314 force-pushed the c/12-20-feat_linter_react_add_version_to_reactpluginsettings_ branch 2 times, most recently from fe17e9a to 6a42403 Compare December 20, 2025 13:38
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 20, 2025
@github-actions github-actions bot added the A-cli Area - CLI label Dec 20, 2025
@camc314 camc314 force-pushed the c/12-20-feat_linter_react_add_version_to_reactpluginsettings_ branch from 6a42403 to a408ae5 Compare December 20, 2025 14:03
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 20, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/12-20-feat_linter_react_add_version_to_reactpluginsettings_ branch from a408ae5 to 9e624c9 Compare December 20, 2025 14:12
@graphite-app graphite-app bot merged commit 9e624c9 into main Dec 20, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-20-feat_linter_react_add_version_to_reactpluginsettings_ branch December 20, 2025 14:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants