feat(linter/react): add version to ReactPluginSettings#17169
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
21b5789 to
675de01
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a version field to the React plugin settings to support version-specific linting rules. The implementation includes a custom ReactVersion type that parses semver-style version strings (e.g., "18.2.0", "17.0") into structured major, minor, and patch components.
Key Changes:
- Added
versionfield (optional) toReactPluginSettingsin Rust - Implemented custom
ReactVersiontype with serde serialization/deserialization - Updated JSON schemas to reflect the new configuration option
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
npm/oxlint/configuration_schema.json |
Added version field to React settings schema and defined ReactVersion type structure |
crates/oxc_linter/src/snapshots/schema_json.snap |
Updated schema snapshot to match the configuration schema changes |
crates/oxc_linter/src/config/settings/react.rs |
Implemented ReactVersion struct with custom deserialization, serialization, and tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #17169 will not alter performanceComparing Summary
Footnotes
|
675de01 to
a45d639
Compare
fe17e9a to
6a42403
Compare
6a42403 to
a408ae5
Compare
Merge activity
|
a408ae5 to
9e624c9
Compare

No description provided.