fix(linter/exhaustive-deps): fix fixer incorrectly adding property chain from destructuring pattern

[camc314]

Fixes #17159

[camc314]

• fix(linter/exhaustive-deps): fix fixer incorrectly adding property chain from destructuring pattern #17167 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[camc314]

Merge activity

• Dec 20, 12:14 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 20, 12:19 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 20, 12:24 PM UTC: Merged by the Graphite merge queue.

[Copilot]

Pull request overview

This PR fixes issue #17159 where the exhaustive-deps linter rule's fixer was incorrectly suggesting property chains from destructuring patterns when the identifier was used inside a function call rather than directly destructured.

Key Changes:

• Added logic to check if an identifier is inside a CallExpression before applying destructuring property chain logic
• Updated error message in snapshot from foo.bar to foo for the affected test case
• Added a new test case to verify the fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/oxc_linter/src/rules/react/exhaustive_deps.rs	Adds a check to prevent applying destructuring logic when an identifier is nested inside a call expression, and adds a test case for the fix
crates/oxc_linter/src/snapshots/react_exhaustive_deps.snap	Updates the expected diagnostic message to correctly identify foo instead of foo.bar as the missing dependency

The implementation is correct and handles the issue appropriately. When an identifier like booleanValue is used as an argument in a function call fn(booleanValue) where the result is destructured (const { headers } = fn(booleanValue)), the dependency should be just booleanValue, not booleanValue.headers. The fix correctly distinguishes this from the case where the identifier is directly destructured (const { headers } = booleanValue), where booleanValue.headers would be the correct dependency.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17167 will not alter performance

_{Comparing c/12-20-fix_linter_exhaustive-deps_fix_fixer_incorrectly_adding_property_chain_from_destructuring_pattern (5c46a39) with main (c7cbe69)}

Summary

✅ 4 untouched
⏩ 41 skipped¹

Footnotes

1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩