Skip to content

feat(linter/no-base-to-string): add checkUnknown option#17139

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-19-feat_linter_no-base-to-string_add_checkunknown_option
Dec 19, 2025
Merged

feat(linter/no-base-to-string): add checkUnknown option#17139
graphite-app[bot] merged 1 commit intomainfrom
c/12-19-feat_linter_no-base-to-string_add_checkunknown_option

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 19, 2025

No description provided.

Copy link
Contributor Author

camc314 commented Dec 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 19, 2025

CodSpeed Performance Report

Merging #17139 will not alter performance

Comparing c/12-19-feat_linter_no-base-to-string_add_checkunknown_option (2f2e4c5) with main (b86a134)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on graphite-base/17139 (e385a04) during the generation of this report, so main (b86a134) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 self-assigned this Dec 19, 2025
@camc314 camc314 force-pushed the c/12-19-feat_linter_no-unsafe-member-access_add_allowoptionalchaining_option branch from 9544aeb to 6773917 Compare December 19, 2025 20:45
@camc314 camc314 force-pushed the c/12-19-feat_linter_no-base-to-string_add_checkunknown_option branch from 7ceb8f1 to 121e1d0 Compare December 19, 2025 20:45
@camc314 camc314 marked this pull request as ready for review December 19, 2025 20:47
@camc314 camc314 force-pushed the c/12-19-feat_linter_no-unsafe-member-access_add_allowoptionalchaining_option branch from 6773917 to 8dec5db Compare December 19, 2025 20:51
@camc314 camc314 force-pushed the c/12-19-feat_linter_no-base-to-string_add_checkunknown_option branch from 121e1d0 to 7aa7e98 Compare December 19, 2025 20:51
@graphite-app graphite-app bot force-pushed the c/12-19-feat_linter_no-unsafe-member-access_add_allowoptionalchaining_option branch 2 times, most recently from 4a7c652 to 0378dcc Compare December 19, 2025 21:08
@graphite-app graphite-app bot force-pushed the c/12-19-feat_linter_no-base-to-string_add_checkunknown_option branch from 7aa7e98 to 8d28750 Compare December 19, 2025 21:08
@graphite-app graphite-app bot force-pushed the c/12-19-feat_linter_no-unsafe-member-access_add_allowoptionalchaining_option branch from 0378dcc to d82cb22 Compare December 19, 2025 21:11
@graphite-app graphite-app bot force-pushed the c/12-19-feat_linter_no-base-to-string_add_checkunknown_option branch from 8d28750 to b683607 Compare December 19, 2025 21:12
@camc314 camc314 force-pushed the c/12-19-feat_linter_no-unsafe-member-access_add_allowoptionalchaining_option branch from d82cb22 to e385a04 Compare December 19, 2025 21:18
@camc314 camc314 force-pushed the c/12-19-feat_linter_no-base-to-string_add_checkunknown_option branch 2 times, most recently from 11099da to 2f2e4c5 Compare December 19, 2025 21:21
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
Copy link
Contributor Author

camc314 commented Dec 19, 2025

Merge activity

  • Dec 19, 9:21 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 19, 9:27 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Dec 19, 9:33 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Dec 19, 9:35 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 19, 9:36 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Dec 19, 9:36 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Dec 19, 9:36 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 19, 9:48 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from c/12-19-feat_linter_no-unsafe-member-access_add_allowoptionalchaining_option to graphite-base/17139 December 19, 2025 21:26
@graphite-app graphite-app bot changed the base branch from graphite-base/17139 to main December 19, 2025 21:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
@camc314 camc314 force-pushed the c/12-19-feat_linter_no-base-to-string_add_checkunknown_option branch from 2f2e4c5 to 5284f98 Compare December 19, 2025 21:35
Copilot AI review requested due to automatic review settings December 19, 2025 21:42
@graphite-app graphite-app bot force-pushed the c/12-19-feat_linter_no-base-to-string_add_checkunknown_option branch from 5284f98 to 5b5f2fd Compare December 19, 2025 21:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 5b5f2fd into main Dec 19, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-19-feat_linter_no-base-to-string_add_checkunknown_option branch December 19, 2025 21:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants