fix(linter/no-unused-private-class-members): handle sequence expression correctly#17127
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of sequence expressions in the no-unused-private-class-members linter rule. Previously, private class members accessed within sequence expressions (e.g., (0, this.#field)) were incorrectly flagged as unused.
Key changes:
- Added
AstKind::SequenceExpression(_)to the list of value contexts where private members are considered "read" - Added a test case validating that private members used in sequence expressions are properly recognized as being used
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #17127 will not alter performanceComparing Summary
Footnotes
|
e42b6f9 to
bfd4a1e
Compare

Closes #17121