Skip to content

fix(vscode): lsp server path in quotes (only windows)#17126

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-19-fix_vscode_lsp_server_path_in_quotes_only_windows_
Dec 19, 2025
Merged

fix(vscode): lsp server path in quotes (only windows)#17126
graphite-app[bot] merged 1 commit intomainfrom
12-19-fix_vscode_lsp_server_path_in_quotes_only_windows_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Dec 19, 2025

Closes: #17124

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Dec 19, 2025
Copy link
Member Author

Sysix commented Dec 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where the LSP server fails to start on Windows when the binary path contains spaces (e.g., in usernames or directory paths). The fix wraps the command path in quotes when running on Windows with a shell.

Key changes:

  • Added quoting of the command path on Windows to handle spaces in paths
  • Introduced isWindows variable to avoid repeating the platform check
  • Updated security comment to reference the correct method name (searchBinaryPath())

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sysix Sysix force-pushed the 12-19-fix_vscode_lsp_server_path_in_quotes_only_windows_ branch from 199b11a to f844c5d Compare December 19, 2025 13:44
@mohitk05
Copy link
Contributor

Closes: #17124

@Sysix Sysix marked this pull request as ready for review December 19, 2025 14:39
@Sysix Sysix requested a review from camc314 as a code owner December 19, 2025 14:39
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
@camc314 camc314 self-assigned this Dec 19, 2025
Copy link
Contributor

camc314 commented Dec 19, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-19-fix_vscode_lsp_server_path_in_quotes_only_windows_ branch from f844c5d to fc6e715 Compare December 19, 2025 15:45
@graphite-app graphite-app bot merged commit fc6e715 into main Dec 19, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 12-19-fix_vscode_lsp_server_path_in_quotes_only_windows_ branch December 19, 2025 15:50
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

language_server: server can't start if there are spaces in the path

4 participants