fix(vscode): lsp server path in quotes (only windows)#17126
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the LSP server fails to start on Windows when the binary path contains spaces (e.g., in usernames or directory paths). The fix wraps the command path in quotes when running on Windows with a shell.
Key changes:
- Added quoting of the command path on Windows to handle spaces in paths
- Introduced
isWindowsvariable to avoid repeating the platform check - Updated security comment to reference the correct method name (
searchBinaryPath())
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
199b11a to
f844c5d
Compare
|
Closes: #17124 |
Merge activity
|
f844c5d to
fc6e715
Compare

Closes: #17124