feat(linter): implement unicorn/no-immediate-mutation rule#17118
Merged
camc314 merged 3 commits intooxc-project:mainfrom Dec 19, 2025
Merged
feat(linter): implement unicorn/no-immediate-mutation rule#17118camc314 merged 3 commits intooxc-project:mainfrom
unicorn/no-immediate-mutation rule#17118camc314 merged 3 commits intooxc-project:mainfrom
Conversation
Implements the `unicorn/no-immediate-mutation` rule that disallows mutating a variable immediately after initialization. Detects: - Array mutations: `array.push()`, `array.unshift()` - Object property assignments: `obj.foo = bar` - Object.assign(): `Object.assign(obj, source)` - Set mutations: `set.add()` - Map mutations: `map.set()` Features: - Handles both variable declarations and assignment expressions - Correctly skips self-referencing mutations (e.g., `array.push(array[0])`) - Supports SwitchCase statement containers - Validates global references for Object/Set/Map to avoid false positives when these identifiers are shadowed
ad16a0b to
cc46b6f
Compare
CodSpeed Performance ReportMerging #17118 will not alter performanceComparing Summary
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
unicorn/no-immediate-mutationrule that disallows mutating a variable immediately after initialization.Closes #9534
What it detects
array.push(),array.unshift()obj.foo = barObject.assign()callsset.add()map.set()Features
array.push(array[0]))Examples
Test plan
AI Assistance Disclosure
I used Codex to review the changes, sanity-check the implementation against existing patterns, and help spot potential edge cases.