Skip to content

perf(oxc_parser): preallocate tokens vector#17095

Closed
lilnasy wants to merge 1 commit intographite-base/17095from
12-19-perf_oxc_parser_preallocate_tokens_vector
Closed

perf(oxc_parser): preallocate tokens vector#17095
lilnasy wants to merge 1 commit intographite-base/17095from
12-19-perf_oxc_parser_preallocate_tokens_vector

Conversation

@lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Dec 19, 2025

No description provided.

Copy link
Contributor Author

lilnasy commented Dec 19, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Dec 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 19, 2025

CodSpeed Performance Report

Merging #17095 will improve performances by 23.28%

Comparing 12-19-perf_oxc_parser_preallocate_tokens_vector (01dc729) with 12-17-feat_oxc_parser_store_tokens_in_lexer_ (f59f6c8)

Summary

⚡ 4 improvements
✅ 42 untouched
⏩ 3 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
Simulation parser[react.development.js] 1.8 ms 1.4 ms +23.28%
Simulation parser[binder.ts] 4.3 ms 3.6 ms +18.74%
Simulation parser[RadixUIAdoptionSection.jsx] 97.1 µs 92.7 µs +4.73%
Simulation parser[cal.com.tsx] 32.7 ms 29.6 ms +10.4%

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@lilnasy lilnasy changed the base branch from 12-17-feat_oxc_parser_store_tokens_in_lexer_ to graphite-base/17095 December 19, 2025 14:59
@camc314 camc314 closed this Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants