Skip to content

feat(linter/no-unnecessary-array-flat-depth): implement fixer #17057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 18, 2025
Merged

feat(linter/no-unnecessary-array-flat-depth): implement fixer #17057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions crates/oxc_linter/src/rules/unicorn/no_unnecessary_array_flat_depth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
use oxc_ast::AstKind;
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::Span;
use oxc_span::{GetSpan, Span};

use crate::{AstNode, ast_util::is_method_call, context::LintContext, rule::Rule};
use crate::{
AstNode, ast_util::is_method_call, context::LintContext, fixer::RuleFixer, rule::Rule,
};

fn no_unnecessary_array_flat_depth_diagnostic(span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Passing `1` as the `depth` argument is unnecessary.")
Expand Down Expand Up @@ -37,7 +39,7 @@ declare_oxc_lint!(
NoUnnecessaryArrayFlatDepth,
unicorn,
pedantic,
pending
suggestion
);

impl Rule for NoUnnecessaryArrayFlatDepth {
Expand All @@ -50,13 +52,18 @@ impl Rule for NoUnnecessaryArrayFlatDepth {
let Some(arg) = call_expr.arguments[0].as_expression() else { return };
let arg = arg.get_inner_expression();
if arg.is_number_value(1.0) {
ctx.diagnostic(no_unnecessary_array_flat_depth_diagnostic(
call_expr
.callee
.as_member_expression()
.and_then(oxc_ast::ast::MemberExpression::static_property_info)
.map_or(call_expr.span, |(span, _)| span),
));
let diagnostic_span = call_expr
.callee
.as_member_expression()
.and_then(oxc_ast::ast::MemberExpression::static_property_info)
.map_or(call_expr.span, |(span, _)| span);

ctx.diagnostic_with_suggestion(
no_unnecessary_array_flat_depth_diagnostic(diagnostic_span),
|fixer: RuleFixer<'_, 'a>| {
fixer.delete_range(Span::new(arg.span().start, call_expr.span.end - 1))
},
);
}
}
}
Expand All @@ -77,6 +84,15 @@ fn test() {

let fail = vec!["foo.flat(1)", "foo.flat(1.0)", "foo.flat(0b01)", "foo?.flat(1)"];

let fix = vec![
("foo.flat(1)", "foo.flat()"),
("foo.flat(1.0)", "foo.flat()"),
("foo.flat(0b01)", "foo.flat()"),
("foo?.flat(1)", "foo?.flat()"),
("foo?.flat(1,)", "foo?.flat()"),
];

Tester::new(NoUnnecessaryArrayFlatDepth::NAME, NoUnnecessaryArrayFlatDepth::PLUGIN, pass, fail)
.expect_fix(fix)
.test_and_snapshot();
}
Loading