feat(linter): implement vitest/prefer-called-times#17051
feat(linter): implement vitest/prefer-called-times#17051camc314 merged 6 commits intooxc-project:mainfrom
Conversation
camc314
left a comment
There was a problem hiding this comment.
This looks to be the same as https://github.com/Boshen/oxc/blob/fc96ee09189a3510078dd0d072a424affdb6dbc4/crates/oxc_linter/src/rules/jest/prefer_to_have_been_called_times.rs#L1, can we take the same approach as 477bb57 / #4956
CodSpeed Performance ReportMerging #17051 will not alter performanceComparing Summary
Footnotes
|
Yes, the two PRs share some code path. I think we could somehow extract the common functions. |
Though the two implements share some common pattern and code path. I'm concerned about they actually check different syntax. Is it appropriate to mix them together? jest/prefer-to-have-been-called-times checks while vitest/prefer-called-times checks |
|
Ah thanks for checking, we can keep them separate |
Ref: #4656
This PR implements vitest/prefer-called-times rule.
Test Plan