Skip to content

test(oxfmt): Add tests for .editorconfig support#17044

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-18-test_oxfmt_add_tests_for_.editorconfig_support
Dec 18, 2025
Merged

test(oxfmt): Add tests for .editorconfig support#17044
graphite-app[bot] merged 1 commit intomainfrom
12-18-test_oxfmt_add_tests_for_.editorconfig_support

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Dec 18, 2025

Fixes #15850

per-file overrides test is currently skipped, I need to fix editor_config_parser crate first.
👉🏻 oxc-project/editorconfig-parser#5
(I will update the test once it becomes available.)

Copy link
Member Author

leaysgur commented Dec 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur changed the title test(oxfmt): Add tests for .editorconfig support test(oxfmt): Add tests for .editorconfig support Dec 18, 2025
@leaysgur leaysgur requested a review from Dunqing December 18, 2025 07:03
@leaysgur leaysgur force-pushed the 12-18-test_oxfmt_add_tests_for_.editorconfig_support branch 2 times, most recently from 5a96e38 to 62cac2e Compare December 18, 2025 07:30
@leaysgur leaysgur force-pushed the 12-18-feat_oxfmt_respect_single_nearest_.editorconfig branch from 6f49f6a to be1da2e Compare December 18, 2025 07:55
@leaysgur leaysgur force-pushed the 12-18-test_oxfmt_add_tests_for_.editorconfig_support branch from 62cac2e to f742308 Compare December 18, 2025 07:55
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 18, 2025
Copy link
Member

Dunqing commented Dec 18, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-18-feat_oxfmt_respect_single_nearest_.editorconfig branch from be1da2e to 06b3434 Compare December 18, 2025 10:42
graphite-app bot pushed a commit that referenced this pull request Dec 18, 2025
Fixes #15850

`per-file overrides` test is currently skipped, I need to fix `editor_config_parser` crate first.
👉🏻 oxc-project/editorconfig-parser#5
(I will update the test once it becomes available.)
@graphite-app graphite-app bot force-pushed the 12-18-test_oxfmt_add_tests_for_.editorconfig_support branch from f742308 to 03910a9 Compare December 18, 2025 10:43
Fixes #15850

`per-file overrides` test is currently skipped, I need to fix `editor_config_parser` crate first.
👉🏻 oxc-project/editorconfig-parser#5
(I will update the test once it becomes available.)
@graphite-app graphite-app bot force-pushed the 12-18-feat_oxfmt_respect_single_nearest_.editorconfig branch from 06b3434 to 15dfb55 Compare December 18, 2025 10:46
@graphite-app graphite-app bot force-pushed the 12-18-test_oxfmt_add_tests_for_.editorconfig_support branch from 03910a9 to 893d9a1 Compare December 18, 2025 10:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 18, 2025
Base automatically changed from 12-18-feat_oxfmt_respect_single_nearest_.editorconfig to main December 18, 2025 10:54
@graphite-app graphite-app bot merged commit 893d9a1 into main Dec 18, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 12-18-test_oxfmt_add_tests_for_.editorconfig_support branch December 18, 2025 10:55
graphite-app bot pushed a commit that referenced this pull request Dec 19, 2025
Follow up #17044

- Set `cwd` to `EditorConfig` to handle absolute path
- Restore skipped tests
graphite-app bot pushed a commit that referenced this pull request Dec 19, 2025
Follow up #17044

- Set `cwd` to `EditorConfig` to handle absolute path
- Restore skipped tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oxfmt: respect .editorconfig

2 participants