Skip to content

Comments

feat(allocator): add bitset utils#17042

Merged
overlookmotel merged 2 commits intooxc-project:mainfrom
zzt1224:12-17-feat_allocator_bitset_utils
Dec 18, 2025
Merged

feat(allocator): add bitset utils#17042
overlookmotel merged 2 commits intooxc-project:mainfrom
zzt1224:12-17-feat_allocator_bitset_utils

Conversation

@zzt1224
Copy link
Contributor

@zzt1224 zzt1224 commented Dec 18, 2025

This PR adds new utility methods unset_bit and union to the BitSet

Note

I used Deepwiki and Copilot.
Well, plus ChatGPT to polish my comment in the code if it's a long one

Copilot AI review requested due to automatic review settings December 18, 2025 05:22
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Dec 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds utility methods to the BitSet data structure, enabling bitwise operations and bit manipulation. The changes enhance the bitset's functionality with operations commonly needed in allocator implementations.

Key changes:

  • Added unset_bit method to clear individual bits
  • Added union method to perform bitwise OR operations between bitsets
  • Renamed test function from union to clone_in and added comprehensive tests for the new methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Boshen
Boshen previously requested changes Dec 18, 2025
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzt1224
Copy link
Contributor Author

zzt1224 commented Dec 18, 2025

This looks AI generated, please follow https://github.com/oxc-project/oxc/blob/main/CONTRIBUTING.md#ai-usage-policy

AI disclosure added!

@Boshen
Copy link
Member

Boshen commented Dec 18, 2025

Given that there's no call sites for these methods, and is AI generated, I'm in favor of closing.

@zzt1224
Copy link
Contributor Author

zzt1224 commented Dec 18, 2025

Given that there's no call sites for these methods, and is AI generated, I'm in favor of closing.

This is not just "ai generated". I use Deepwiki and Copilot when I’m working on the OXC project. This is from another PR and was reviewed by @overlookmotel

#15466 (review)

@Boshen
Copy link
Member

Boshen commented Dec 18, 2025

Given that there's no call sites for these methods, and is AI generated, I'm in favor of closing.

This is not just "ai generated". I use Deepwiki and Copilot when I’m working on the OXC project. This is from another PR and was reviewed by @overlookmotel

#15466 (review)

Thank you for the context.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 18, 2025

CodSpeed Performance Report

Merging #17042 will not alter performance

Comparing zzt1224:12-17-feat_allocator_bitset_utils (1140d45) with main (9190c4b)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on main (b48d5f1) during the generation of this report, so 9190c4b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

zzt1224 and others added 2 commits December 18, 2025 18:57
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: zhaoting zhou <zhaotingzhou@esri.com>
@overlookmotel overlookmotel force-pushed the 12-17-feat_allocator_bitset_utils branch from 5019f29 to 1140d45 Compare December 18, 2025 18:57
@overlookmotel overlookmotel merged commit fb2af91 into oxc-project:main Dec 18, 2025
28 checks passed
overlookmotel added a commit that referenced this pull request Dec 19, 2025
### 🚀 Features

- d209c21 allocator: Add cap to FixedSizeAllocatorPool and block when
exhausted (#17023) (Cameron)
- fb2af91 allocator: Add bitset utils (#17042) (zhaoting zhou)
- c16082c tasks/compat_data: Integrate `node-compat-table` (#16831)
(Boshen)
- 5586823 span: Extract TS declaration file check to its own function
(#17037) (camchenry)
- 3d2b492 minifier: Fold iife arrow functions in call expressions
(#16477) (Armano)
- 67e9f9e codegen: Keep comments on the export specifiers (#16943)
(夕舞八弦)
- cb515fa parser: Improve error message for `yield` as identifier usage
(#16950) (sapphi-red)
- dcc856b parser: Add help for `new_dynamic_import` error (#16949)
(sapphi-red)
- c3c79f8 parser: Improve import attribute value error message (#16948)
(sapphi-red)
- 291b57b ast_tools: Generate TS declaration files for deserializer and
walk files (#16912) (camc314)
- 74eae13 minifier: Remove unused import specifiers (#16797) (camc314)

### 🐛 Bug Fixes

- fb9e193 linter: OOM problems with custom plugins (#17082)
(overlookmotel)
- e59132b parser/napi: Fix lazy deser (#17069) (overlookmotel)
- a92faf0 ast_tools: Support `u128` in `assert_layouts` generator
(#17050) (overlookmotel)
- 47b4c2f minifier/docs: Correct hyperlink path in OPTIMIZATIONS.md
(#16986) (GRK)
- 3002649 transformer/typescript: Remove unused import equals
declaration (#16776) (Dunqing)
- 5a2af88 regular_expression: Correct named capture group reference
error (#16952) (sapphi-red)

### ⚡ Performance

- b657bb6 allocator: Reduce time `Mutex` lock is held in
`FixedSizeAllocatorPool::get` (#17079) (overlookmotel)
- 1f3b19b ast: `#[ast]` macro use `#[repr(transparent)]` for
single-field structs (#17052) (overlookmotel)
- 225f229 parser: Use SmallVec for duplicate default export detection
(#16801) (camc314)

### 📚 Documentation

- a9c419f traverse: Update safety comments (#16944) (overlookmotel)

Co-authored-by: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants