fix(linter): Allow oxlint directives in comments without capitalizing them with eslint/capitalized-comments.#16984
fix(linter): Allow oxlint directives in comments without capitalizing them with eslint/capitalized-comments.#16984connorshea wants to merge 2 commits intomainfrom
Conversation
… them. And add relevant tests. Following up on #16896.
There was a problem hiding this comment.
Pull request overview
This PR extends the capitalized_comments rule to recognize and ignore oxlint-specific comment directives, preventing false positives when oxlint directives are written in lowercase. The change allows developers to use oxlint directives (like // oxlint-disable-line) without being forced to capitalize them according to the comment capitalization rules.
Key changes:
- Added
oxlint-disable,oxlint-enable, andoxlintto the DIRECTIVES array - Added pass tests to verify oxlint directives are properly ignored in both default and "always" capitalization modes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #16984 will not alter performanceComparing Summary
Footnotes
|
|
I think this can be closed as I merged #16989 first? |
And add relevant tests. Following up on #16896.
This is technically deviating from the original rule's behavior, but that seems fine in this case.