Skip to content

Comments

fix(linter): Allow oxlint directives in comments without capitalizing them with eslint/capitalized-comments.#16984

Closed
connorshea wants to merge 2 commits intomainfrom
no-cap-frfr
Closed

fix(linter): Allow oxlint directives in comments without capitalizing them with eslint/capitalized-comments.#16984
connorshea wants to merge 2 commits intomainfrom
no-cap-frfr

Conversation

@connorshea
Copy link
Member

And add relevant tests. Following up on #16896.

This is technically deviating from the original rule's behavior, but that seems fine in this case.

… them.

And add relevant tests.

Following up on #16896.
Copilot AI review requested due to automatic review settings December 17, 2025 06:31
@connorshea connorshea requested a review from camc314 as a code owner December 17, 2025 06:31
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Dec 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the capitalized_comments rule to recognize and ignore oxlint-specific comment directives, preventing false positives when oxlint directives are written in lowercase. The change allows developers to use oxlint directives (like // oxlint-disable-line) without being forced to capitalize them according to the comment capitalization rules.

Key changes:

  • Added oxlint-disable, oxlint-enable, and oxlint to the DIRECTIVES array
  • Added pass tests to verify oxlint directives are properly ignored in both default and "always" capitalization modes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 17, 2025

CodSpeed Performance Report

Merging #16984 will not alter performance

Comparing no-cap-frfr (6de7b5e) with main (3002649)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314
Copy link
Contributor

camc314 commented Dec 17, 2025

I think this can be closed as I merged #16989 first?

@camc314 camc314 closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants