chore(pnpm): move workspace devDependencies to used packages#16982
Merged
chore(pnpm): move workspace devDependencies to used packages#16982
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the monorepo's dependency management by moving workspace-level devDependencies to the individual packages that actually use them. This aligns with the principle of making dependencies visible only where they are needed, reducing unnecessary dependency resolution in packages that don't require them.
Key Changes
- Moved
@napi-rs/clifrom root workspace to all packages that use NAPI builds - Moved
publintto packages that perform package validation - Added
@arethetypeswrong/coreto the catalog and distributed it to packages using type checking - Removed unused workspace-level dependencies (
emnapi,eslint,typescript,vitest)
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pnpm-workspace.yaml |
Added @arethetypeswrong/core to the catalog |
pnpm-lock.yaml |
Updated lockfile with new dependency resolutions and added @InQuirer snapshots for @types/node@24.1.0 |
package.json |
Removed workspace-level devDependencies that are now defined per-package |
apps/oxfmt/package.json |
Added @napi-rs/cli as devDependency |
apps/oxfmt/tsdown.config.ts |
Added attw configuration for type checking |
apps/oxlint/package.json |
Added @arethetypeswrong/core and @napi-rs/cli as devDependencies |
napi/minify/package.json |
Added @napi-rs/cli and publint as devDependencies |
napi/parser/package.json |
Added @napi-rs/cli and publint as devDependencies |
napi/playground/package.json |
Added @napi-rs/cli and publint as devDependencies |
napi/transform/package.json |
Added @napi-rs/cli and publint as devDependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Boshen
force-pushed
the
12-17-chore_pnpm_put_packages_in_the_right_place
branch
7 times, most recently
from
2bb8248 to
475c49d
Compare
To ensure monorepo dependencies are only visible to where they are used.
Boshen
force-pushed
the
12-17-chore_pnpm_put_packages_in_the_right_place
branch
from
475c49d to
331d0ad
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 17, 2025
#16982 moved the Oxlint JS plugin that we use for linting this repo into `plugins` directory. Add a `tsconfig.json` file to this directly so TS understands it. Also rename the plugin file to `.ts` - it only had to be `.mts` previously because it was in root of the repo.
qinyuhang
pushed a commit
to qinyuhang/oxc
that referenced
this pull request
Jan 22, 2026
…ject#16982) To ensure monorepo dependencies are only visible to where they are used.
qinyuhang
pushed a commit
to qinyuhang/oxc
that referenced
this pull request
Jan 22, 2026
oxc-project#16982 moved the Oxlint JS plugin that we use for linting this repo into `plugins` directory. Add a `tsconfig.json` file to this directly so TS understands it. Also rename the plugin file to `.ts` - it only had to be `.mts` previously because it was in root of the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure monorepo dependencies are only visible to where they are used.