Skip to content

feat(codegen): keep comments on the export specifiers #16943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 2 commits into from
Dec 16, 2025
Merged

feat(codegen): keep comments on the export specifiers #16943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58239e6
fix: keep comments on the export specifiers
daflyinbed Dec 16, 2025
147b212
u
Boshen Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/oxc_codegen/src/gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,11 +1054,19 @@ impl Gen for ExportSpecifier<'_> {
if self.export_kind.is_type() {
p.print_str("type ");
}
if let Some(comments) = p.get_comments(self.local.span().start) {
p.print_comments(&comments);
p.print_soft_space();
}
self.local.print(p, ctx);
let local_name = get_module_export_name(&self.local, p);
let exported_name = get_module_export_name(&self.exported, p);
if local_name != exported_name {
p.print_str(" as ");
if let Some(comments) = p.get_comments(self.exported.span().start) {
p.print_comments(&comments);
p.print_soft_space();
}
self.exported.print(p, ctx);
}
}
Expand Down
5 changes: 5 additions & 0 deletions crates/oxc_codegen/tests/integration/comments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ fn unit() {
"function foo() { return /*i18n*/ {} }",
"function foo() {\n\treturn (\t/*i18n*/ {});\n}\n",
);

test_same("export { /** @deprecated */ parseAst } from \"rolldown/parseAst\";\n");
test_same("export { /** @deprecated */ parseAst };\n");
test_same("export { parseAst as /** @deprecated */ b } from \"rolldown/parseAst\";\n");
test_same("export { parseAst as /** @deprecated */ b };\n");
}

pub mod jsdoc {
Expand Down
12 changes: 6 additions & 6 deletions crates/oxc_codegen/tests/integration/snapshots/ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,15 +317,15 @@ export class ClassName {}
export function* generatorFunctionName() {/* … */}
export const { name5, name2: bar } = o;
export const [name6, name7] = array;
export { name8, name81 };
export { variable1 as name9, variable2 as name10, name82 };
export { variable1 as 'string name' };
export { name8, /* …, */ name81 };
export { variable1 as name9, variable2 as name10, /* …, */ name82 };
export { variable1 as 'string name' };
export { name1 as default1 };
export * from 'module-name';
export * as name11 from 'module-name';
export { name12, nameN } from 'module-name';
export { import1 as name13, import2 as name14, name15 } from 'module-name';
export { default } from 'module-name';
export { name12, /* …, */ nameN } from 'module-name';
export { import1 as name13, import2 as name14, /* …, */ name15 } from 'module-name';
export { default } from 'module-name';
export { default as name16 } from 'module-name';

########## 41
Expand Down
Loading