refactor(formatter/oxfmtrc): Fix up Oxfmtrc and oxfmtrc.rs

[leaysgur]

This is a refactoring related to the Oxfmtrc struct.

• Clearly state that defined in oxc_formatter is temporary
  • Also changed export path
• Remove useless default attribute from Oxfmtrc
  • Defaults are resolved by into_options()
• Mark all SortImportsConfig fields as Option
  • Aligned with Oxfmtrc, needed for Node.js API
• Move from_file() to oxc_language_server, which only used by here

[leaysgur]

• feat(oxfmt): Expose Node.js API: format(fileName, sourceText, options?) #16939
• test(oxfmt): Test ignorePatterns is inserted at the bottom #16936
• refactor(oxfmt): Align usage of napi::block_on() #16935
• refactor(oxfmt): Allow to call setupConfig() multiple times #16934
• refactor(formatter/oxfmtrc): Fix up Oxfmtrc and oxfmtrc.rs #16933 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #16933 will not alter performance

_{Comparing 12-16-refactor_formatter_oxfmtrc_fix_up_oxfmtrc.rs (5ea9f08) with main (c897794)¹}

Summary

✅ 42 untouched
⏩ 3 skipped²

Footnotes

1. No successful run was found on main (ce943c6) during the generation of this report, so c897794 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR refactors the Oxfmtrc configuration struct to improve its design and maintainability. The primary goals are to clarify that the struct's current location in oxc_formatter is temporary (due to circular dependencies), remove unnecessary default attributes that are handled elsewhere, align SortImportsConfig fields with the Option-based pattern used throughout Oxfmtrc, and move the from_file() method to its only user (oxc_language_server).

Key Changes:

• Added documentation explaining why Oxfmtrc is temporarily in oxc_formatter instead of apps/oxfmt
• Removed #[default] attributes from config enums since defaults are resolved during into_options() conversion
• Changed all SortImportsConfig fields to Option types with improved documentation showing defaults
• Moved from_file() method from oxfmtrc.rs to oxc_language_server as it's the only consumer
• Restructured module exports: oxfmtrc is now a public module, and parse_utils content moved to service/mod.rs

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_formatter/src/oxfmtrc.rs	Added explanatory comments, removed enum #[default] attributes, changed SortImportsConfig to use Option fields, removed from_file() method, refactored into_options() to handle Option unwrapping
crates/oxc_formatter/src/lib.rs	Changed oxfmtrc from private module to public, simplified service exports
crates/oxc_formatter/src/service/mod.rs	Merged parse_utils.rs content directly into mod.rs
crates/oxc_formatter/src/service/parse_utils.rs	File deleted (content moved to mod.rs)
crates/oxc_formatter/Cargo.toml	Removed json-strip-comments dependency (moved to language server)
crates/oxc_language_server/src/formatter/server_formatter.rs	Added from_file() method, updated imports to new oxfmtrc module path
crates/oxc_language_server/Cargo.toml	Added json-strip-comments dependency
apps/oxfmt/src/core/config.rs	Updated imports to use new oxfmtrc module path
Test files and schemas	Updated imports and regenerated JSON schemas with new descriptions showing default values
Cargo.lock	Reflects dependency movement between crates

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[graphite-app]

Merge activity

• Dec 16, 11:39 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Dec 16, 11:47 AM UTC: Merged by the Graphite merge queue.