Skip to content

fix(linter/plugins): apply defaults from meta.schema to options #16930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 16, 2025
Merged

fix(linter/plugins): apply defaults from meta.schema to options #16930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
318 changes: 5 additions & 313 deletions apps/oxlint/conformance/snapshot.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
| Status | Count | % |
| ----------------- | ----- | ------ |
| Total rules | 277 | 100.0% |
| Fully passing | 217 | 78.3% |
| Partially passing | 59 | 21.3% |
| Fully passing | 218 | 78.7% |
| Partially passing | 58 | 20.9% |
| Fully failing | 1 | 0.4% |
| Load errors | 0 | 0.0% |
| No tests run | 0 | 0.0% |
Expand All @@ -18,8 +18,8 @@
| Status | Count | % |
| ----------- | ----- | ------ |
| Total tests | 29765 | 100.0% |
| Passing | 28671 | 96.3% |
| Failing | 987 | 3.3% |
| Passing | 28673 | 96.3% |
| Failing | 985 | 3.3% |
| Skipped | 107 | 0.4% |

## Fully Passing Rules
Expand All @@ -38,6 +38,7 @@
- `class-methods-use-this` (156 tests)
- `comma-spacing` (173 tests)
- `comma-style` (96 tests)
- `computed-property-spacing` (125 tests)
- `curly` (216 tests)
- `default-case-last` (37 tests)
- `default-case` (23 tests)
Expand Down Expand Up @@ -247,7 +248,6 @@
- `block-scoped-var` - 97 / 106 (91.5%)
- `camelcase` - 187 / 204 (91.7%)
- `comma-dangle` - 265 / 267 (99.3%)
- `computed-property-spacing` - 123 / 125 (98.4%)
- `consistent-this` - 23 / 26 (88.5%)
- `func-call-spacing` - 137 / 151 (90.7%)
- `id-blacklist` - 120 / 131 (91.6%)
Expand Down Expand Up @@ -1585,314 +1585,6 @@ AssertionError [ERR_ASSERTION]: Should have 2 errors but had 1: [
at apps/oxlint/dist/index.js


### `computed-property-spacing`

Pass: 123 / 125 (98.4%)
Fail: 2 / 125 (1.6%)
Skip: 0 / 125 (0.0%)

#### computed-property-spacing > invalid

```js
A = class { [ a ](){} get [ b ](){} set [ c ](foo){} static [ d ](){} static get [ e ](){} static set [ f ](bar){} }
```

```json
{
"output": "A = class { [a](){} get [b](){} set [c](foo){} static [d](){} static get [e](){} static set [f](bar){} }",
"options": [
"never",
{}
],
"languageOptions": {
"ecmaVersion": 6
},
"errors": [
{
"messageId": "unexpectedSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 14,
"endLine": 1,
"endColumn": 15
},
{
"messageId": "unexpectedSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 16,
"endLine": 1,
"endColumn": 17
},
{
"messageId": "unexpectedSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 28,
"endLine": 1,
"endColumn": 29
},
{
"messageId": "unexpectedSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 30,
"endLine": 1,
"endColumn": 31
},
{
"messageId": "unexpectedSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 42,
"endLine": 1,
"endColumn": 43
},
{
"messageId": "unexpectedSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 44,
"endLine": 1,
"endColumn": 45
},
{
"messageId": "unexpectedSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 62,
"endLine": 1,
"endColumn": 63
},
{
"messageId": "unexpectedSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 64,
"endLine": 1,
"endColumn": 65
},
{
"messageId": "unexpectedSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 83,
"endLine": 1,
"endColumn": 84
},
{
"messageId": "unexpectedSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 85,
"endLine": 1,
"endColumn": 86
},
{
"messageId": "unexpectedSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 104,
"endLine": 1,
"endColumn": 105
},
{
"messageId": "unexpectedSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 106,
"endLine": 1,
"endColumn": 107
}
]
}
```

AssertionError [ERR_ASSERTION]: Should have 12 errors but had 0: []

0 !== 12

at assertErrorCountIsCorrect (apps/oxlint/dist/index.js)
at assertInvalidTestCasePasses (apps/oxlint/dist/index.js)
at runInvalidTestCase (apps/oxlint/dist/index.js)
at apps/oxlint/dist/index.js


#### computed-property-spacing > invalid

```js
class A { [a](){} get [b](){} set [c](foo){} static [d](){} static get [e](){} static set [f](bar){} }
```

```json
{
"output": "class A { [ a ](){} get [ b ](){} set [ c ](foo){} static [ d ](){} static get [ e ](){} static set [ f ](bar){} }",
"options": [
"always",
{}
],
"languageOptions": {
"ecmaVersion": 6
},
"errors": [
{
"messageId": "missingSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 11,
"endLine": 1,
"endColumn": 12
},
{
"messageId": "missingSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 13,
"endLine": 1,
"endColumn": 14
},
{
"messageId": "missingSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 23,
"endLine": 1,
"endColumn": 24
},
{
"messageId": "missingSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 25,
"endLine": 1,
"endColumn": 26
},
{
"messageId": "missingSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 35,
"endLine": 1,
"endColumn": 36
},
{
"messageId": "missingSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 37,
"endLine": 1,
"endColumn": 38
},
{
"messageId": "missingSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 53,
"endLine": 1,
"endColumn": 54
},
{
"messageId": "missingSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 55,
"endLine": 1,
"endColumn": 56
},
{
"messageId": "missingSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 72,
"endLine": 1,
"endColumn": 73
},
{
"messageId": "missingSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 74,
"endLine": 1,
"endColumn": 75
},
{
"messageId": "missingSpaceAfter",
"data": {
"tokenValue": "["
},
"line": 1,
"column": 91,
"endLine": 1,
"endColumn": 92
},
{
"messageId": "missingSpaceBefore",
"data": {
"tokenValue": "]"
},
"line": 1,
"column": 93,
"endLine": 1,
"endColumn": 94
}
]
}
```

AssertionError [ERR_ASSERTION]: Should have 12 errors but had 0: []

0 !== 12

at assertErrorCountIsCorrect (apps/oxlint/dist/index.js)
at assertInvalidTestCasePasses (apps/oxlint/dist/index.js)
at runInvalidTestCase (apps/oxlint/dist/index.js)
at apps/oxlint/dist/index.js


### `consistent-this`

Pass: 23 / 26 (88.5%)
Expand Down
2 changes: 2 additions & 0 deletions apps/oxlint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@
"devDependencies": {
"@types/esquery": "^1.5.4",
"@types/estree": "^1.0.8",
"@types/json-schema": "^7.0.15",
"@types/json-stable-stringify-without-jsonify": "^1.0.2",
"@typescript-eslint/scope-manager": "8.48.1",
"ajv": "^6.12.6",
"cross-env": "catalog:",
"eslint": "^9.36.0",
"esquery": "^1.6.0",
Expand Down
Loading
Loading