Skip to content

fix(oxfmt): place ignorePatterns at bottom of JSON in --migrate prettier #16926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 16, 2025
Merged

fix(oxfmt): place ignorePatterns at bottom of JSON in --migrate prettier #16926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/oxfmt/src-js/migration/migrate-prettier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,12 @@ export async function runMigratePrettier() {

// Migrate `ignorePatterns` from `.prettierignore`
const ignores = await resolvePrettierIgnore(cwd);
if (0 < ignores.length) {
oxfmtrc.ignorePatterns = ignores;
if (ignores.length > 0) {
console.log("Migrated ignore patterns from `.prettierignore`");
}
// Keep ignorePatterns at the bottom
delete oxfmtrc.ignorePatterns;
oxfmtrc.ignorePatterns = ignores;

const jsonStr = JSON.stringify(oxfmtrc, null, 2);

Expand Down
2 changes: 1 addition & 1 deletion apps/oxfmt/src-js/migration/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export async function createBlankOxfmtrcFile(cwd: string) {
const config: Record<string, unknown> = {
// Add `$schema` field at the top if schema file exists in `node_modules`
$schema: schemaPath,
// `ignorePatterns` is included to make visible and preferred over `.prettierignore`
// `ignorePatterns` is included to make it visible and preferred over `.prettierignore`
ignorePatterns: [],
};

Expand Down
Loading