refactor(linter/plugins): move RuleOptionsSchema type into options.ts#16901
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR refactors the location of the RuleOptionsSchema type definition by moving it from rule_meta.ts to options.ts, which is a more semantically appropriate location since it's an options-related type. The refactor maintains backward compatibility by updating all import and export statements accordingly.
Key Changes:
- Moved
RuleOptionsSchematype definition fromrule_meta.tstooptions.ts - Updated import statements in
rule_meta.tsto import the type from its new location - Updated public API exports in
index.tsto reflect the new source location
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/oxlint/src-js/plugins/rule_meta.ts |
Removed RuleOptionsSchema type definition and added import from options.ts |
apps/oxlint/src-js/plugins/options.ts |
Added RuleOptionsSchema type definition with its JSDoc comments and TODO notes |
apps/oxlint/src-js/index.ts |
Updated export statement to export RuleOptionsSchema from options.ts instead of rule_meta.ts |
The refactor looks good! The type definition has been moved cleanly with all documentation and comments preserved. The import/export chain is properly updated:
rule_meta.tsnow importsRuleOptionsSchemafromoptions.ts(along withOptions)index.tsexportsRuleOptionsSchemafromoptions.tsinstead ofrule_meta.ts- The public API surface remains unchanged - consumers can still import
RuleOptionsSchemafrom the main package
All usages of the type are accounted for and the refactor is complete.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
….ts` (#16901) Pure refactor. Move the type def for `RuleOptionsSchema` into `options.ts`, which is a more appropriate place for it.
e56778b to
3183bf8
Compare
830acac to
f3d439f
Compare

Pure refactor. Move the type def for
RuleOptionsSchemaintooptions.ts, which is a more appropriate place for it.