Skip to content

refactor(linter/plugins): move RuleOptionsSchema type into options.ts#16901

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-15-refactor_linter_plugins_move_ruleoptionsschema_type_into_options.ts_
Dec 15, 2025
Merged

refactor(linter/plugins): move RuleOptionsSchema type into options.ts#16901
graphite-app[bot] merged 1 commit intomainfrom
12-15-refactor_linter_plugins_move_ruleoptionsschema_type_into_options.ts_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 15, 2025

Pure refactor. Move the type def for RuleOptionsSchema into options.ts, which is a more appropriate place for it.

Copy link
Member Author

overlookmotel commented Dec 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Dec 15, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Dec 15, 2025
@overlookmotel overlookmotel marked this pull request as ready for review December 15, 2025 12:56
Copilot AI review requested due to automatic review settings December 15, 2025 12:56
@overlookmotel overlookmotel self-assigned this Dec 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the location of the RuleOptionsSchema type definition by moving it from rule_meta.ts to options.ts, which is a more semantically appropriate location since it's an options-related type. The refactor maintains backward compatibility by updating all import and export statements accordingly.

Key Changes:

  • Moved RuleOptionsSchema type definition from rule_meta.ts to options.ts
  • Updated import statements in rule_meta.ts to import the type from its new location
  • Updated public API exports in index.ts to reflect the new source location

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
apps/oxlint/src-js/plugins/rule_meta.ts Removed RuleOptionsSchema type definition and added import from options.ts
apps/oxlint/src-js/plugins/options.ts Added RuleOptionsSchema type definition with its JSDoc comments and TODO notes
apps/oxlint/src-js/index.ts Updated export statement to export RuleOptionsSchema from options.ts instead of rule_meta.ts

The refactor looks good! The type definition has been moved cleanly with all documentation and comments preserved. The import/export chain is properly updated:

  • rule_meta.ts now imports RuleOptionsSchema from options.ts (along with Options)
  • index.ts exports RuleOptionsSchema from options.ts instead of rule_meta.ts
  • The public API surface remains unchanged - consumers can still import RuleOptionsSchema from the main package

All usages of the type are accounted for and the refactor is complete.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 15, 2025
Copy link
Member Author

overlookmotel commented Dec 15, 2025

Merge activity

….ts` (#16901)

Pure refactor. Move the type def for `RuleOptionsSchema` into `options.ts`, which is a more appropriate place for it.
@graphite-app graphite-app bot force-pushed the 12-15-docs_linter_plugins_fix_typo_in_jsdoc_comment branch from e56778b to 3183bf8 Compare December 15, 2025 13:06
@graphite-app graphite-app bot force-pushed the 12-15-refactor_linter_plugins_move_ruleoptionsschema_type_into_options.ts_ branch from 830acac to f3d439f Compare December 15, 2025 13:06
Base automatically changed from 12-15-docs_linter_plugins_fix_typo_in_jsdoc_comment to main December 15, 2025 13:11
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 15, 2025
@graphite-app graphite-app bot merged commit f3d439f into main Dec 15, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 12-15-refactor_linter_plugins_move_ruleoptionsschema_type_into_options.ts_ branch December 15, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants