Skip to content

feat(linter): implement eslint/no-inline-comments #16885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 6 commits into from
Dec 15, 2025
Merged

feat(linter): implement eslint/no-inline-comments #16885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
28bd5ad
feat(linter): implement eslint/no-inline-comments
tt-a1i Dec 15, 2025
821dbd7
[autofix.ci] apply automated fixes
autofix-ci[bot] Dec 15, 2025
f991ff7
fix(linter): add JSON schema and fix clippy lint for no-inline-comments
tt-a1i Dec 15, 2025
d6291b3
fix(linter): escape HTML tags in doc comments for no-inline-comments
tt-a1i Dec 15, 2025
3c9610d
u
camc314 Dec 15, 2025
f52c745
u
camc314 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,11 @@ impl RuleRunner for crate::rules::eslint::no_import_assign::NoImportAssign {
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

impl RuleRunner for crate::rules::eslint::no_inline_comments::NoInlineComments {
const NODE_TYPES: Option<&AstTypesBitset> = None;
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::RunOnce;
}

impl RuleRunner for crate::rules::eslint::no_inner_declarations::NoInnerDeclarations {
const NODE_TYPES: Option<&AstTypesBitset> =
Some(&AstTypesBitset::from_types(&[AstType::Function, AstType::VariableDeclaration]));
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ pub(crate) mod eslint {
pub mod no_global_assign;
pub mod no_implicit_coercion;
pub mod no_import_assign;
pub mod no_inline_comments;
pub mod no_inner_declarations;
pub mod no_invalid_regexp;
pub mod no_irregular_whitespace;
Expand Down Expand Up @@ -710,6 +711,7 @@ oxc_macros::declare_all_lint_rules! {
eslint::max_params,
eslint::new_cap,
eslint::no_implicit_coercion,
eslint::no_inline_comments,
eslint::no_loop_func,
eslint::no_useless_computed_key,
eslint::no_unassigned_vars,
Expand Down
Loading
Loading