Skip to content

perf(parser): use SmallVec for duplicate default export detection #16801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 15, 2025
Merged

perf(parser): use SmallVec for duplicate default export detection #16801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions crates/oxc_parser/src/module_record.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,8 @@ impl<'a> ModuleRecordBuilder<'a> {
.indirect_export_entries
.iter()
.filter_map(|export_entry| export_entry.export_name.default_export_span()),
)
.collect::<std::vec::Vec<_>>();
if default_exports.len() > 1 {
);
if default_exports.clone().count() > 1 {
errors.push(
OxcDiagnostic::error("Duplicated default export").with_labels(default_exports),
);
Expand Down
2 changes: 1 addition & 1 deletion tasks/track_memory_allocations/allocs_parser.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ File | File size || Sys allocs | Sys reallocs |
-------------------------------------------------------------------------------------------------------------------------------------------
checker.ts | 2.92 MB || 9672 | 21 || 267681 | 22847

cal.com.tsx | 1.06 MB || 2212 | 62 || 138162 | 13699
cal.com.tsx | 1.06 MB || 2211 | 62 || 138162 | 13699

RadixUIAdoptionSection.jsx | 2.52 kB || 1 | 0 || 365 | 66

Expand Down
Loading