Skip to content

chore(linter): Remove one last reference to the regexp plugin.#16772

Merged
graphite-app[bot] merged 1 commit intomainfrom
rm-regex
Dec 12, 2025
Merged

chore(linter): Remove one last reference to the regexp plugin.#16772
graphite-app[bot] merged 1 commit intomainfrom
rm-regex

Conversation

@connorshea
Copy link
Member

Eliminate one more reference that was still lingering.

Copilot AI review requested due to automatic review settings December 12, 2025 06:59
@connorshea connorshea requested a review from camc314 as a code owner December 12, 2025 06:59
@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 12, 2025
Copy link

@charliecreates charliecreates bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in the modified code. The change cleanly removes the final regexp plugin reference and falls back to the default _ => plugin_name behavior without introducing complexity or behavioral ambiguity beyond the intended removal.

Summary of changes

What changed

  • Removed the last remaining mapping for the regexp plugin in plugin_name_to_prefix() by deleting the match arm:
    • "regexp" => "eslint-plugin-regexp"

Files touched

  • crates/oxc_linter/src/context/mod.rs

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the last remaining reference to the eslint-plugin-regexp plugin from the codebase. The plugin_name_to_prefix function previously mapped the short plugin name "regexp" to "eslint-plugin-regexp", but since the regexp plugin has been completely removed from the linter (no rules directory exists for it), this mapping is no longer needed.

Key Changes:

  • Removed the "regexp" case from the plugin_name_to_prefix function's match statement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 12, 2025

CodSpeed Performance Report

Merging #16772 will not alter performance

Comparing rm-regex (e380b35) with main (d221921)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 12, 2025
@camc314 camc314 self-assigned this Dec 12, 2025
Copy link
Contributor

camc314 commented Dec 12, 2025

Merge activity

Eliminate one more reference that was still lingering.
@graphite-app graphite-app bot merged commit fbcb49a into main Dec 12, 2025
20 checks passed
@graphite-app graphite-app bot deleted the rm-regex branch December 12, 2025 11:31
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants