Skip to content

fix(semantic): add TS error code 1235 to namespace declaration diagnostic#16747

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-11-fix_semantic_add_ts_error_code_1235_to_namespace_declaration_diagnostic
Dec 11, 2025
Merged

fix(semantic): add TS error code 1235 to namespace declaration diagnostic#16747
graphite-app[bot] merged 1 commit intomainfrom
c/12-11-fix_semantic_add_ts_error_code_1235_to_namespace_declaration_diagnostic

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 11, 2025

Add TypeScript error code to the "namespace declaration not allowed" error message for consistency with other TS diagnostics.

🤖 generated with help from Claude Opus 4.5

Copy link
Contributor Author

camc314 commented Dec 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review December 11, 2025 11:59
@camc314 camc314 requested a review from Dunqing as a code owner December 11, 2025 11:59
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 11, 2025

CodSpeed Performance Report

Merging #16747 will not alter performance

Comparing c/12-11-fix_semantic_add_ts_error_code_1235_to_namespace_declaration_diagnostic (d7f300a) with c/12-11-feat_semantic_add_ts_2670_error_for_global_scope_augmentation_without_declare_modifier (e177d94)

Summary

✅ 42 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 11, 2025
Copy link
Member

Boshen commented Dec 11, 2025

Merge activity

…stic (#16747)

Add TypeScript error code to the "namespace declaration not allowed" error message for consistency with other TS diagnostics.

🤖 generated with help from Claude Opus 4.5
@graphite-app graphite-app bot force-pushed the c/12-11-feat_semantic_add_ts_2670_error_for_global_scope_augmentation_without_declare_modifier branch from e177d94 to 083e081 Compare December 11, 2025 13:27
@graphite-app graphite-app bot force-pushed the c/12-11-fix_semantic_add_ts_error_code_1235_to_namespace_declaration_diagnostic branch from d7f300a to 92788c7 Compare December 11, 2025 13:28
Base automatically changed from c/12-11-feat_semantic_add_ts_2670_error_for_global_scope_augmentation_without_declare_modifier to main December 11, 2025 13:34
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 11, 2025
@graphite-app graphite-app bot merged commit 92788c7 into main Dec 11, 2025
21 checks passed
@graphite-app graphite-app bot deleted the c/12-11-fix_semantic_add_ts_error_code_1235_to_namespace_declaration_diagnostic branch December 11, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants