refactor(oxfmt): Rename FormatFileSource > FormatFileStrategy#16635
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 10, 2025
Merged
Conversation
github-actions
bot
added
A-cli
This was referenced Dec 9, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
leaysgur
changed the title
FormatFileSource > FormatFileStrategy
Dunqing
approved these changes
Dec 10, 2025
Member
Merge activity
|
graphite-app
bot
force-pushed
the
12-08-feat_oxfmt_enable_experimental_package.json_sorting_by_default
branch
from
8649cfa to
28e0682
Compare
graphite-app
bot
force-pushed
the
12-09-refactor_oxfmt_rename_formatfilesource_formatfilestrategy
branch
from
7292230 to
569abe2
Compare
Base automatically changed from
12-08-feat_oxfmt_enable_experimental_package.json_sorting_by_default
to
main
December 10, 2025 01:53
graphite-app
bot
deleted the
12-09-refactor_oxfmt_rename_formatfilesource_formatfilestrategy
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…c-project#16635) Addressed review in oxc-project#16593 - Add `OxfmtOptions` struct - Rename `FormatFileSource` to `FormatFileStrategy` - And include `package.json` as `ExternalFormatterPackageJson` variant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed review in #16593
OxfmtOptionsstructFormatFileSourcetoFormatFileStrategypackage.jsonasExternalFormatterPackageJsonvariant