Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/oxlint/src-js/package/rule_tester.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ const DEFAULT_SHARED_CONFIG: Config = {
};

// `RuleTester` uses this config as its default. Can be overwritten via `RuleTester.setDefaultConfig()`.
let sharedConfig: Config = DEFAULT_SHARED_CONFIG;
// Clone, so that user can't get `DEFAULT_SHARED_CONFIG` with `getDefaultConfig()` and modify it.
let sharedConfig: Config = { ...DEFAULT_SHARED_CONFIG };

// ------------------------------------------------------------------------------
// Test cases
Expand Down Expand Up @@ -254,7 +255,8 @@ export class RuleTester {
* @returns {void}
*/
static resetDefaultConfig() {
sharedConfig = DEFAULT_SHARED_CONFIG;
// Clone, so that user can't get `DEFAULT_SHARED_CONFIG` with `getDefaultConfig()` and modify it
sharedConfig = { ...DEFAULT_SHARED_CONFIG };
}

// Getters/setters for `describe` and `it` functions
Expand Down
27 changes: 27 additions & 0 deletions apps/oxlint/test/rule_tester.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,33 @@ describe("RuleTester", () => {
]);
});

describe("config", () => {
// TODO: More tests for config

it("can be set globally", () => {
const config = { whatever: true };
RuleTester.setDefaultConfig(config);
expect(RuleTester.getDefaultConfig()).toBe(config);
});

it("is reset to default by `resetDefaultConfig`", () => {
RuleTester.setDefaultConfig({ whatever: true });
expect(RuleTester.getDefaultConfig()).toHaveProperty("whatever", true);

RuleTester.resetDefaultConfig();
expect(RuleTester.getDefaultConfig()).not.toHaveProperty("whatever");
});

it("cannot permanently change default config", () => {
const defaultConfig = RuleTester.getDefaultConfig();
defaultConfig.whatever = true;
expect(RuleTester.getDefaultConfig()).toBe(defaultConfig);

RuleTester.resetDefaultConfig();
expect(RuleTester.getDefaultConfig()).not.toHaveProperty("whatever");
});
});

describe("tests valid cases", () => {
it("which are correct", () => {
const tester = new RuleTester();
Expand Down
Loading