Skip to content

docs(linter/plugins): add TODO comment #16511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 4, 2025
Merged

docs(linter/plugins): add TODO comment #16511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/oxlint/src-js/plugins/location.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ export function initLines(): void {
if (sourceText === null) initSourceText();
debugAssertIsNonNull(sourceText);

// TODO: ESLint freezes `lines`, but doesn't freeze `lineStartIndices`.
// Should we freeze them? Upside is it would prevent user mutating them, but on downside would prevent us re-using
// the same arrays for multiple files. Maybe we shouldn't bother, in same way that we don't freeze the AST.
// Once we introduce lazy deserialization, presumably we'll use proxy arrays (like `NodeArray`), which will make
// them immutable by user. Maybe we can leave it until then. (@overlookmotel)

// This implementation is based on the one in ESLint.
// TODO: Investigate if using `String.prototype.matchAll` is faster.
// This comment is above ESLint's implementation:
Expand Down
Loading