refactor(linter/plugins): rename tokensAndComments var#16500
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 4, 2025
Merged
Conversation
This was referenced Dec 4, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
overlookmotel
force-pushed
the
12-04-refactor_linter_plugins_rename_tokensandcomments_var
branch
2 times, most recently
from
a8ee644 to
71e5a9e
Compare
overlookmotel
force-pushed
the
12-04-feat_linter_plugins_add_sourcecode_isestree_property
branch
from
1425b32 to
cbd7d22
Compare
This was referenced Dec 4, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a pure refactoring to align the internal naming convention with ESLint by renaming the internal variable tokensWithComments to tokensAndComments throughout the tokens plugin implementation. The change affects variable names, function names, comments, and error messages to maintain consistency.
- Renamed internal variable
tokensWithCommentstotokensAndComments - Renamed initialization function
initTokensWithComments()toinitTokensAndComments() - Renamed debug validation function
debugCheckTokensWithComments()todebugCheckTokensAndComments()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
Pure refactor. Rename `tokensWithComments` to `tokensAndComments`, to match ESLint.
graphite-app
bot
force-pushed
the
12-04-feat_linter_plugins_add_sourcecode_isestree_property
branch
from
cbd7d22 to
d2ca540
Compare
graphite-app
bot
force-pushed
the
12-04-refactor_linter_plugins_rename_tokensandcomments_var
branch
from
71e5a9e to
333172f
Compare
Base automatically changed from
12-04-feat_linter_plugins_add_sourcecode_isestree_property
to
main
December 4, 2025 16:47
graphite-app
bot
deleted the
12-04-refactor_linter_plugins_rename_tokensandcomments_var
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…#16500) Pure refactor. Rename `tokensWithComments` to `tokensAndComments`, to match ESLint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Rename
tokensWithCommentstotokensAndComments, to match ESLint.