Skip to content

refactor(formatter): simplify checking multiline block comment#16481

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-04-refactor_formatter_simplify_checking_multiline_block_comment
Dec 9, 2025
Merged

refactor(formatter): simplify checking multiline block comment#16481
graphite-app[bot] merged 1 commit intomainfrom
12-04-refactor_formatter_simplify_checking_multiline_block_comment

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 4, 2025

use Comment::is_multiline_block to check whether the comment has a line break

@github-actions github-actions bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 4, 2025
Copy link
Member Author

Dunqing commented Dec 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2025

CodSpeed Performance Report

Merging #16481 will not alter performance

Comparing 12-04-refactor_formatter_simplify_checking_multiline_block_comment (00e08ca) with 12-04-feat_ast_parser_codegen_add_commentkind_multineblock (4c95de1)1

Summary

✅ 38 untouched
⏩ 7 skipped2

Footnotes

  1. No successful run was found on 12-04-feat_ast_parser_codegen_add_commentkind_multineblock (77d4387) during the generation of this report, so 3e17b64 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing force-pushed the 12-04-refactor_formatter_simplify_checking_multiline_block_comment branch from dee5796 to 545c1c8 Compare December 4, 2025 09:51
@Dunqing Dunqing force-pushed the 12-04-feat_ast_parser_codegen_add_commentkind_multineblock branch from b30e61f to 6f67bf0 Compare December 4, 2025 09:51
@Dunqing Dunqing force-pushed the 12-04-refactor_formatter_simplify_checking_multiline_block_comment branch from 545c1c8 to 163deaa Compare December 4, 2025 14:30
@Dunqing Dunqing force-pushed the 12-04-feat_ast_parser_codegen_add_commentkind_multineblock branch from 4640f6c to d72ed7f Compare December 4, 2025 14:30
@github-actions github-actions bot added the A-parser Area - Parser label Dec 4, 2025
@Dunqing Dunqing force-pushed the 12-04-feat_ast_parser_codegen_add_commentkind_multineblock branch from 1b8e61a to 482f237 Compare December 4, 2025 14:39
@Dunqing Dunqing force-pushed the 12-04-refactor_formatter_simplify_checking_multiline_block_comment branch from 8125287 to 7f42bf5 Compare December 4, 2025 14:39
@Dunqing Dunqing marked this pull request as ready for review December 4, 2025 14:40
@Dunqing Dunqing force-pushed the 12-04-feat_ast_parser_codegen_add_commentkind_multineblock branch from 482f237 to 4c95de1 Compare December 4, 2025 14:45
@Dunqing Dunqing force-pushed the 12-04-refactor_formatter_simplify_checking_multiline_block_comment branch from 7f42bf5 to 77c20fe Compare December 4, 2025 14:45
@Dunqing Dunqing force-pushed the 12-04-feat_ast_parser_codegen_add_commentkind_multineblock branch from 4c95de1 to 77d4387 Compare December 7, 2025 15:25
@Dunqing Dunqing force-pushed the 12-04-refactor_formatter_simplify_checking_multiline_block_comment branch from 77c20fe to 00e08ca Compare December 7, 2025 15:25
@Dunqing Dunqing requested a review from leaysgur December 9, 2025 00:39
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
Copy link
Member Author

Dunqing commented Dec 9, 2025

Merge activity

use `Comment::is_multiline_block` to check whether the comment has a line break
@graphite-app graphite-app bot force-pushed the 12-04-feat_ast_parser_codegen_add_commentkind_multineblock branch from 2bdaad6 to 30a9076 Compare December 9, 2025 02:02
@graphite-app graphite-app bot force-pushed the 12-04-refactor_formatter_simplify_checking_multiline_block_comment branch from 00e08ca to 5014335 Compare December 9, 2025 02:02
Base automatically changed from 12-04-feat_ast_parser_codegen_add_commentkind_multineblock to main December 9, 2025 02:08
@graphite-app graphite-app bot merged commit 5014335 into main Dec 9, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-04-refactor_formatter_simplify_checking_multiline_block_comment branch December 9, 2025 02:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
use `Comment::is_multiline_block` to check whether the comment has a line break
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
…roject#16481)

use `Comment::is_multiline_block` to check whether the comment has a line break
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants