refactor(linter): rename visitor.d.ts to visitor.ts#16473
Closed
refactor(linter): rename visitor.d.ts to visitor.ts#16473
Conversation
github-actions
bot
added
A-linter
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
approved these changes
Dec 3, 2025
Member
Merge activity
|
camc314
changed the base branch from
c/12-03-fix_linter_use_import_type_for_estree_in_visitor.d.ts
to
graphite-base/16473
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 7, 2025
Use `import type` instead of `import` for type-only imports to follow, TypeScript best practices. This is also in prepartation for #16473 which converts this file to a `.ts` file rather than a declaration file. Using a `.ts` file is an advantage as it means that typescript will actually check it rather than skipping it ([skipLibCheck](https://www.typescriptlang.org/tsconfig/#skipLibCheck)) 🤖 generated with help from Claude Opus 4.5
…ith index signature Use intersection type instead of interface to avoid TypeScript strict mode errors when using defineRule with specific visitor methods like Program(). Closes #14745
graphite-app
bot
force-pushed
the
graphite-base/16473
branch
from
cbec81d to
a806d74
Compare
graphite-app
bot
force-pushed
the
c/12-03-refactor_linter_rename_visitor.d.ts_to_visitor.ts
branch
from
64d9644 to
2a5f6e8
Compare
Rename from declaration file to regular TypeScript file since it only contains type exports and is not accompanying a JavaScript file. Closes #14745
graphite-app
bot
force-pushed
the
c/12-03-refactor_linter_rename_visitor.d.ts_to_visitor.ts
branch
from
2a5f6e8 to
1d2b03d
Compare
Contributor
Author
|
Closing for now, need to think about this more |
camc314
deleted the
c/12-03-refactor_linter_rename_visitor.d.ts_to_visitor.ts
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…16472) Use `import type` instead of `import` for type-only imports to follow, TypeScript best practices. This is also in prepartation for oxc-project#16473 which converts this file to a `.ts` file rather than a declaration file. Using a `.ts` file is an advantage as it means that typescript will actually check it rather than skipping it ([skipLibCheck](https://www.typescriptlang.org/tsconfig/#skipLibCheck)) 🤖 generated with help from Claude Opus 4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
visitor.d.tsfrom a typescript declaration file to a normal typescript file. This allows the typescript type checker to actuall check for issues in this file.e.g. before #16471: we had tons of errors that were supressed because this wasn't being type checked.