Skip to content

fix(linter/oxc): not emit error when the threshold is zero and we haven't detected a barrel file #16455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 2 commits into from
Dec 3, 2025
Merged

fix(linter/oxc): not emit error when the threshold is zero and we haven't detected a barrel file #16455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94da408
fix(linter/oxc): not emit error when the threshold is zero and we hav…
Afsoon Dec 3, 2025
2f36306
fix lint
camc314 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion crates/oxc_linter/src/rules/oxc/no_barrel_file.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ impl Rule for NoBarrelFile {
}

let threshold = self.threshold;
if total >= threshold {
if total > threshold {
if labels.is_empty() {
labels.push(Span::new(0, 0).label("File defined here."));
}
Expand Down Expand Up @@ -148,6 +148,17 @@ fn test() {
(r#"export type { foo } from "foo";"#, None),
(r#"export type * from "foo"; export type { bar } from "bar";"#, None),
(r#"import { foo, bar, baz } from "../import/export-star/models";"#, None),
(
r#"import boo from "foo";
const test = 0;"#,
Some(serde_json::json!([{"threshold": 0}])),
),
(r"export const test = 0;", Some(serde_json::json!([{"threshold": 0}]))),
(
r"export const test = 0;
export const other = 1;",
Some(serde_json::json!([{"threshold": 0}])),
),
];

let settings = Some(serde_json::json!([{"threshold": 1}]));
Expand Down
Loading