Skip to content

perf(napi/parser): do not remove extraneous options on JS side #16447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 3, 2025
Merged

perf(napi/parser): do not remove extraneous options on JS side #16447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions napi/parser/src-js/raw-transfer/eager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ const require = createRequire(import.meta.url);
* @returns {Object} - Object with property getters for `program`, `module`, `comments`, and `errors`
*/
export function parseSyncRaw(filename, sourceText, options) {
let _;
({ experimentalRawTransfer: _, ...options } = options);
return parseSyncRawImpl(filename, sourceText, options, deserialize);
}

Expand All @@ -36,8 +34,6 @@ export function parseSyncRaw(filename, sourceText, options) {
* @returns {Object} - Object with property getters for `program`, `module`, `comments`, and `errors`
*/
export function parse(filename, sourceText, options) {
let _;
({ experimentalRawTransfer: _, ...options } = options);
return parseAsyncRawImpl(filename, sourceText, options, deserialize);
}

Expand Down
4 changes: 0 additions & 4 deletions napi/parser/src-js/raw-transfer/lazy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ export { Visitor } from "./visitor.js";
* and `dispose` and `visit` methods
*/
export function parseSyncLazy(filename, sourceText, options) {
let _;
({ experimentalLazy: _, ...options } = options);
return parseSyncRawImpl(filename, sourceText, options, construct);
}

Expand Down Expand Up @@ -63,8 +61,6 @@ export function parseSyncLazy(filename, sourceText, options) {
* and `dispose` and `visit` methods
*/
export function parse(filename, sourceText, options) {
let _;
({ experimentalLazy: _, ...options } = options);
return parseAsyncRawImpl(filename, sourceText, options, construct);
}

Expand Down
Loading