Skip to content

Comments

refactor(formatter/sort-imports): Resolve default options.(internalPattern|groups) in options.rs#16375

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-02-refactor_formatter_sort-imports_resolve_default_options.internalpattern_in_options.rs
Dec 2, 2025
Merged

refactor(formatter/sort-imports): Resolve default options.(internalPattern|groups) in options.rs#16375
graphite-app[bot] merged 1 commit intomainfrom
12-02-refactor_formatter_sort-imports_resolve_default_options.internalpattern_in_options.rs

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Dec 2, 2025

Yet another pure refactoring.

@leaysgur leaysgur requested a review from Dunqing as a code owner December 2, 2025 05:02
@github-actions github-actions bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 2, 2025
Copy link
Member Author

leaysgur commented Dec 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur force-pushed the 12-02-refactor_formatter_sort-imports_resolve_default_options.internalpattern_in_options.rs branch from 626a996 to 692a714 Compare December 2, 2025 05:10
@leaysgur leaysgur changed the title refactor(formatter/sort-imports): Resolve default options.internalPattern in options.rs refactor(formatter/sort-imports): Resolve default options.internalPattern in options.rs Dec 2, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 2, 2025

CodSpeed Performance Report

Merging #16375 will not alter performance

Comparing 12-02-refactor_formatter_sort-imports_resolve_default_options.internalpattern_in_options.rs (aa94f59) with 12-02-refactor_formatter_sort-imports_move_sortimportsoptions_to_sort_imports_options.rs (e4124ca)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur marked this pull request as draft December 2, 2025 05:18
@leaysgur leaysgur force-pushed the 12-02-refactor_formatter_sort-imports_resolve_default_options.internalpattern_in_options.rs branch from 692a714 to aa94f59 Compare December 2, 2025 05:30
@leaysgur leaysgur changed the title refactor(formatter/sort-imports): Resolve default options.internalPattern in options.rs refactor(formatter/sort-imports): Resolve default options.(internalPattern|groups) in options.rs Dec 2, 2025
@leaysgur leaysgur marked this pull request as ready for review December 2, 2025 05:35
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 2, 2025
Copy link
Member

Dunqing commented Dec 2, 2025

Merge activity

…attern|groups)` in `options.rs` (#16375)

Yet another pure refactoring.
@graphite-app graphite-app bot force-pushed the 12-02-refactor_formatter_sort-imports_move_sortimportsoptions_to_sort_imports_options.rs branch from e4124ca to e5a78ed Compare December 2, 2025 07:37
@graphite-app graphite-app bot force-pushed the 12-02-refactor_formatter_sort-imports_resolve_default_options.internalpattern_in_options.rs branch from aa94f59 to 8c2d09f Compare December 2, 2025 07:38
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 2, 2025
Base automatically changed from 12-02-refactor_formatter_sort-imports_move_sortimportsoptions_to_sort_imports_options.rs to main December 2, 2025 07:44
@graphite-app graphite-app bot merged commit 8c2d09f into main Dec 2, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-02-refactor_formatter_sort-imports_resolve_default_options.internalpattern_in_options.rs branch December 2, 2025 07:44
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
…attern|groups)` in `options.rs` (oxc-project#16375)

Yet another pure refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants