Skip to content

fix(linter/valid-title): preserve escape sequences in fixer output #16348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 1, 2025
Merged

fix(linter/valid-title): preserve escape sequences in fixer output #16348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions crates/oxc_linter/src/rules/jest/valid_title.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,10 @@ fn validate_title(
if !valid_title.ignore_space && trimmed_title != title {
let (error, help) = Message::AccidentalSpace.detail();
ctx.diagnostic_with_fix(valid_title_diagnostic(error, help, span), |fixer| {
fixer.replace(span.shrink(1), trimmed_title.to_string())
let inner_span = span.shrink(1);
let raw_text = fixer.source_range(inner_span);
let trimmed_raw = raw_text.trim().to_string();
fixer.replace(inner_span, trimmed_raw)
});
}

Expand All @@ -399,8 +402,14 @@ fn validate_title(
if first_word == un_prefixed_name {
let (error, help) = Message::DuplicatePrefix.detail();
ctx.diagnostic_with_fix(valid_title_diagnostic(error, help, span), |fixer| {
let replaced_title = title[first_word.len()..].trim().to_string();
fixer.replace(span.shrink(1), replaced_title)
// Use raw source text to preserve escape sequences
let inner_span = span.shrink(1);
let raw_text = fixer.source_range(inner_span);
// Find the first space in raw text to avoid byte offset issues
// if the prefix word ever contains escapable characters
let space_pos = raw_text.find(' ').unwrap_or(raw_text.len());
let replaced_raw = raw_text[space_pos..].trim().to_string();
fixer.replace(inner_span, replaced_raw)
});
return;
}
Expand Down Expand Up @@ -1136,6 +1145,16 @@ fn test() {
})
",
),
// AccidentalSpace: preserve escape sequences when trimming spaces
(
"test('issue #225513: Cmd-Click doesn\\'t work on JSDoc {@link URL|LinkText} format ', () => { assert(true); });",
"test('issue #225513: Cmd-Click doesn\\'t work on JSDoc {@link URL|LinkText} format', () => { assert(true); });",
),
// DuplicatePrefix: preserve escape sequences when removing prefix
(
"test('test that it doesn\\'t break', () => {});",
"test('that it doesn\\'t break', () => {});",
),
];

Tester::new(ValidTitle::NAME, ValidTitle::PLUGIN, pass, fail)
Expand Down
Loading