Skip to content

Comments

refactor(linter): rename RuleEnum::read_json to from_configuration#16340

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-01-refactor_linter_rename_ruleenum_read_json_to_from_configuration_
Dec 1, 2025
Merged

refactor(linter): rename RuleEnum::read_json to from_configuration#16340
graphite-app[bot] merged 1 commit intomainfrom
12-01-refactor_linter_rename_ruleenum_read_json_to_from_configuration_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 1, 2025

Pure refactor. RuleEnum::read_json delegates to the rule's from_configuration method. So it makes more sense IMO for this method to be called from_configuration too. This follows the same pattern as the rest of RuleEnum's methods.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 1, 2025
Copy link
Member Author

overlookmotel commented Dec 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025

CodSpeed Performance Report

Merging #16340 will not alter performance

Comparing 12-01-refactor_linter_rename_ruleenum_read_json_to_from_configuration_ (7c78fab) with 12-01-perf_linter_avoid_cloning_rule_options (c39aaa5)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on 12-01-perf_linter_avoid_cloning_rule_options (1286efc) during the generation of this report, so 27c8971 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot force-pushed the 12-01-refactor_linter_store_rule_options_as_vec_s branch from 2876176 to ec38b61 Compare December 1, 2025 13:52
@graphite-app graphite-app bot force-pushed the 12-01-refactor_linter_rename_ruleenum_read_json_to_from_configuration_ branch from ccf4217 to ed096a5 Compare December 1, 2025 13:52
@overlookmotel overlookmotel changed the base branch from 12-01-refactor_linter_store_rule_options_as_vec_s to graphite-base/16340 December 1, 2025 14:26
@overlookmotel overlookmotel changed the base branch from graphite-base/16340 to 12-01-refactor_linter_store_rule_options_as_vec_s December 1, 2025 14:26
@overlookmotel overlookmotel changed the base branch from 12-01-refactor_linter_store_rule_options_as_vec_s to graphite-base/16340 December 1, 2025 14:29
@overlookmotel overlookmotel changed the base branch from graphite-base/16340 to 12-01-refactor_linter_store_rule_options_as_vec_s December 1, 2025 14:30
@overlookmotel overlookmotel changed the base branch from 12-01-refactor_linter_store_rule_options_as_vec_s to graphite-base/16340 December 1, 2025 14:30
@overlookmotel overlookmotel force-pushed the 12-01-refactor_linter_rename_ruleenum_read_json_to_from_configuration_ branch from ed096a5 to 7c78fab Compare December 1, 2025 14:30
@overlookmotel overlookmotel changed the base branch from graphite-base/16340 to 12-01-perf_linter_avoid_cloning_rule_options December 1, 2025 14:30
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
Copy link
Contributor

camc314 commented Dec 1, 2025

Merge activity

#16340)

Pure refactor. `RuleEnum::read_json` delegates to the rule's `from_configuration` method. So it makes more sense IMO for this method to be called `from_configuration` too. This follows the same pattern as the rest of `RuleEnum`'s methods.
@graphite-app graphite-app bot force-pushed the 12-01-perf_linter_avoid_cloning_rule_options branch from 1286efc to 3026086 Compare December 1, 2025 15:51
@graphite-app graphite-app bot force-pushed the 12-01-refactor_linter_rename_ruleenum_read_json_to_from_configuration_ branch from 7c78fab to f1660c2 Compare December 1, 2025 15:52
Base automatically changed from 12-01-perf_linter_avoid_cloning_rule_options to main December 1, 2025 15:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
@graphite-app graphite-app bot merged commit f1660c2 into main Dec 1, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-01-refactor_linter_rename_ruleenum_read_json_to_from_configuration_ branch December 1, 2025 15:58
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
oxc-project#16340)

Pure refactor. `RuleEnum::read_json` delegates to the rule's `from_configuration` method. So it makes more sense IMO for this method to be called `from_configuration` too. This follows the same pattern as the rest of `RuleEnum`'s methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants