refactor(linter): rename RuleEnum::read_json to from_configuration#16340
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #16340 will not alter performanceComparing Summary
Footnotes
|
2876176 to
ec38b61
Compare
ccf4217 to
ed096a5
Compare
ed096a5 to
7c78fab
Compare
ec38b61 to
1286efc
Compare
Merge activity
|
#16340) Pure refactor. `RuleEnum::read_json` delegates to the rule's `from_configuration` method. So it makes more sense IMO for this method to be called `from_configuration` too. This follows the same pattern as the rest of `RuleEnum`'s methods.
1286efc to
3026086
Compare
7c78fab to
f1660c2
Compare
oxc-project#16340) Pure refactor. `RuleEnum::read_json` delegates to the rule's `from_configuration` method. So it makes more sense IMO for this method to be called `from_configuration` too. This follows the same pattern as the rest of `RuleEnum`'s methods.

Pure refactor.
RuleEnum::read_jsondelegates to the rule'sfrom_configurationmethod. So it makes more sense IMO for this method to be calledfrom_configurationtoo. This follows the same pattern as the rest ofRuleEnum's methods.