Skip to content

Comments

refactor(formatter): clean up dead code in JSX#16319

Merged
leaysgur merged 1 commit intomainfrom
12-01-refactor_formatter_clean_up_dead_code_in_jsx
Dec 1, 2025
Merged

refactor(formatter): clean up dead code in JSX#16319
leaysgur merged 1 commit intomainfrom
12-01-refactor_formatter_clean_up_dead_code_in_jsx

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 1, 2025

Pure refactor, those are dead code

@github-actions github-actions bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 1, 2025
Copy link
Member Author

Dunqing commented Dec 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025

CodSpeed Performance Report

Merging #16319 will not alter performance

Comparing 12-01-refactor_formatter_clean_up_dead_code_in_jsx (01b8ed7) with 12-01-fix_formatter_jsx_text_wrapping_incorrect (2b8f982)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing marked this pull request as ready for review December 1, 2025 03:02
@Dunqing Dunqing requested a review from leaysgur December 1, 2025 03:04
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
Copy link
Member Author

Dunqing commented Dec 1, 2025

Merge activity

  • Dec 1, 5:01 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 1, 5:37 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 1, 5:41 AM UTC: leaysgur added this pull request to the Graphite merge queue.

@Dunqing Dunqing force-pushed the 12-01-refactor_formatter_clean_up_dead_code_in_jsx branch from 47f8821 to cfab9df Compare December 1, 2025 05:31
@Dunqing Dunqing force-pushed the 12-01-fix_formatter_jsx_text_wrapping_incorrect branch from eeef31f to 0309770 Compare December 1, 2025 05:31
@leaysgur leaysgur added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Dec 1, 2025
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
@graphite-app graphite-app bot force-pushed the 12-01-fix_formatter_jsx_text_wrapping_incorrect branch from 0309770 to 2b8f982 Compare December 1, 2025 05:44
@graphite-app graphite-app bot force-pushed the 12-01-refactor_formatter_clean_up_dead_code_in_jsx branch from cfab9df to 01b8ed7 Compare December 1, 2025 05:45
Base automatically changed from 12-01-fix_formatter_jsx_text_wrapping_incorrect to main December 1, 2025 05:50
@leaysgur leaysgur merged commit d3e4354 into main Dec 1, 2025
27 checks passed
@leaysgur leaysgur deleted the 12-01-refactor_formatter_clean_up_dead_code_in_jsx branch December 1, 2025 05:54
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Pure refactor, those are dead code

Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants