fix(formatter): Fix line comment after : inside ternary JSX

[leaysgur]

Fixes #16258

[leaysgur]

• fix(formatter): Fix line comment after : inside ternary JSX #16315 👈 (View in Graphite)
• fix(formatter): Add parens for new: private field expr #16312
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #16315 will not alter performance

_{Comparing 12-01-fix_formatter_fix_jsx_ternary_line_comment_after_ (5931c84) with main (decf2ad)}

Summary

✅ 38 untouched
⏩ 7 skipped¹

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Dunqing]

Handling comments is complicated, so I will take a careful look.

[leaysgur]

Yes, I just appreciate. 🙏🏻

[Copilot]

Pull request overview

This PR fixes formatting of line comments appearing after the : operator in ternary expressions within JSX elements. The fix addresses issue #16258 where such comments were not being handled correctly by the formatter.

Key changes:

• Unified comment handling logic for JSX elements and fragments
• Refactored conditional expression formatting to improve code clarity

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
crates/oxc_formatter/src/write/jsx/element.rs	Simplified format_trailing_comments to use end_of_line_comments_after uniformly for non-arrow function cases
crates/oxc_formatter/src/utils/conditional.rs	Refactored format_test to compute span values outside the formatting closure for better readability
crates/oxc_formatter/tests/fixtures/js/jsx/ternary-with-comment.jsx	Added test case for nested ternary with comment after : operator
crates/oxc_formatter/tests/fixtures/js/jsx/ternary-with-comment.jsx.snap	Updated snapshot with expected formatting output for new test case

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Dunqing]

I found out that this should be fixed on the JSX side, and I re-implemented it. Please take a look!

[leaysgur]

Merge activity

• Dec 1, 12:25 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 1, 12:25 PM UTC: leaysgur added this pull request to the Graphite merge queue.
• Dec 1, 12:35 PM UTC: Merged by the Graphite merge queue.

[leaysgur]

Thank you so much...! (I never thought of that. 🤯)