perf(span): add #[inline] to Atom methods#16311
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 1, 2025
Merged
Conversation
github-actions
bot
added
the
C-performance
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #16311 will not alter performanceComparing Summary
Footnotes
|
Member
Author
|
I think the benchmark changes (both positive and negative) are likely just noise. But that's not unexpected (see above). For the reasons given above I still think it's a good idea. |
Member
Author
Merge activity
|
Add `#[inline]` / `#[inline(always)]` to trivial methods of `Atom`. In Oxc, this will very likely make no difference, as we compile with LTO. But it would likely make a significant difference to users who consume `oxc_span` crate directly, and don't utilize LTO, as without `#[inline]` or LTO, compiler will not inline across crate boundaries.
graphite-app
bot
force-pushed
the
12-01-perf_span_add_repr_transparent_to_atom_
branch
from
9efe73c to
ffca070
Compare
graphite-app
bot
force-pushed
the
12-01-perf_span_add_inline_to_atom_methods
branch
from
410ad59 to
cc2f352
Compare
Base automatically changed from
12-01-perf_span_add_repr_transparent_to_atom_
to
main
December 1, 2025 02:36
graphite-app
bot
deleted the
12-01-perf_span_add_inline_to_atom_methods
branch
overlookmotel
pushed a commit
that referenced
this pull request
Dec 1, 2025
### 💥 BREAKING CHANGES - 74cf572 ast: [**BREAKING**] Make `source` field of `TSImportType` a `StringLiteral` (#16114) (copilot-swe-agent) - 43156ae ast: [**BREAKING**] Rename `TSImportType` `argument` field to `source` (#16110) (overlookmotel) - 934d873 napi: [**BREAKING**] Drop `armv7-unknown-linux-musleabihf` support (#16105) (Boshen) ### 🚀 Features - 669afe0 ast: Add `Expression::is_jsx` method (#16154) (Dunqing) - 17a8caa parser: Add diagnostic for JSX identifiers with hyphens (#16133) (camchenry) - 0549ae5 parser: Add diagnostic for expected ident after optional chain (#16132) (camchenry) - db839ae parser: Improve diagnostic for unexpected optional declarations (#16131) (camchenry) - bab4bc8 napi/parser: Add type annotations to parse-raw-worker test (#15998) (camc314) ### 🐛 Bug Fixes - 35ed36c traverse: Fix panic when truncating non-ASCII variable names (#16265) (peter) - 9149a26 linter/plugins, napi/parser: Deep freeze visitor keys (#16293) (overlookmotel) - 6b54dab minifier: Incorrect non-null object condition simplification with `&&` and `||` (#16161) (sapphi-red) - 9cc20a1 minifier: Avoid merging side effectful expressions to next assignment statement if the side effect may change the left hand side reference (#16165) (sapphi-red) - 91eb3f2 ast/estree: Convert `TSImportType` `argument` field to `Literal` (#16109) (overlookmotel) - 1199cee parser: Reject invalid modifiers on parameter properties with binding patterns (#16083) (camc314) - f376325 traverse: Remove `console.log` from build script (#16049) (overlookmotel) ### ⚡ Performance - 82d784f lexer: Reduce bounds checks in `Lexer::get_string` (#16317) (overlookmotel) - cc2f352 span: Add `#[inline]` to `Atom` methods (#16311) (overlookmotel) - ffca070 span: Add `#[repr(transparent)]` to `Atom` (#16310) (overlookmotel) - 02bdf90 linter/plugins, napi/parser: Reuse arrays in visitor keys (#16294) (overlookmotel) ### 📚 Documentation - 891e0b4 parser: Add note about falling back to parse TSType in TSImportType (#16119) (camc314) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
Add `#[inline]` / `#[inline(always)]` to trivial methods of `Atom`. In Oxc, this will very likely make no difference, as we compile with LTO. But it would likely make a significant difference to users who consume `oxc_span` crate directly, and don't utilize LTO, as without `#[inline]` or LTO, compiler will not inline across crate boundaries.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
### 💥 BREAKING CHANGES - 74cf572 ast: [**BREAKING**] Make `source` field of `TSImportType` a `StringLiteral` (oxc-project#16114) (copilot-swe-agent) - 43156ae ast: [**BREAKING**] Rename `TSImportType` `argument` field to `source` (oxc-project#16110) (overlookmotel) - 934d873 napi: [**BREAKING**] Drop `armv7-unknown-linux-musleabihf` support (oxc-project#16105) (Boshen) ### 🚀 Features - 669afe0 ast: Add `Expression::is_jsx` method (oxc-project#16154) (Dunqing) - 17a8caa parser: Add diagnostic for JSX identifiers with hyphens (oxc-project#16133) (camchenry) - 0549ae5 parser: Add diagnostic for expected ident after optional chain (oxc-project#16132) (camchenry) - db839ae parser: Improve diagnostic for unexpected optional declarations (oxc-project#16131) (camchenry) - bab4bc8 napi/parser: Add type annotations to parse-raw-worker test (oxc-project#15998) (camc314) ### 🐛 Bug Fixes - 35ed36c traverse: Fix panic when truncating non-ASCII variable names (oxc-project#16265) (peter) - 9149a26 linter/plugins, napi/parser: Deep freeze visitor keys (oxc-project#16293) (overlookmotel) - 6b54dab minifier: Incorrect non-null object condition simplification with `&&` and `||` (oxc-project#16161) (sapphi-red) - 9cc20a1 minifier: Avoid merging side effectful expressions to next assignment statement if the side effect may change the left hand side reference (oxc-project#16165) (sapphi-red) - 91eb3f2 ast/estree: Convert `TSImportType` `argument` field to `Literal` (oxc-project#16109) (overlookmotel) - 1199cee parser: Reject invalid modifiers on parameter properties with binding patterns (oxc-project#16083) (camc314) - f376325 traverse: Remove `console.log` from build script (oxc-project#16049) (overlookmotel) ### ⚡ Performance - 82d784f lexer: Reduce bounds checks in `Lexer::get_string` (oxc-project#16317) (overlookmotel) - cc2f352 span: Add `#[inline]` to `Atom` methods (oxc-project#16311) (overlookmotel) - ffca070 span: Add `#[repr(transparent)]` to `Atom` (oxc-project#16310) (overlookmotel) - 02bdf90 linter/plugins, napi/parser: Reuse arrays in visitor keys (oxc-project#16294) (overlookmotel) ### 📚 Documentation - 891e0b4 parser: Add note about falling back to parse TSType in TSImportType (oxc-project#16119) (camc314) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
#[inline]/#[inline(always)]to trivial methods ofAtom.In Oxc, this will very likely make no difference, as we compile with LTO. But it would likely make a significant difference to users who consume
oxc_spancrate directly, and don't utilize LTO, as without#[inline]or LTO, compiler will not inline across crate boundaries.