test(lsp): add tests for removing folders in workspace/didChangeWorkspaceFolders notification#16308
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 1, 2025
Conversation
github-actions
bot
added
A-editor
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for the workspace/didChangeWorkspaceFolders notification when folders are removed, complementing the existing tests for adding folders. The changes extract common helper functions to reduce code duplication and introduce a constant for the workspace URI.
Key changes:
- Added
WORKSPACEconstant to centralize the workspace URI string - Extracted
shutdown()method for tests without watchers - Extracted
acknowledge_unregistrations()helper function - Added two new test cases:
test_workspace_removed(without watchers) andtest_workspace_removed_watchers(with watchers)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
approved these changes
Dec 1, 2025
graphite-app
bot
changed the base branch from
11-30-fix_lsp_watch_for_files_when_workspace_folder_is_added_workspace_configuration_is_not_supported
to
graphite-base/16308
graphite-app
bot
force-pushed
the
graphite-base/16308
branch
from
8b6830d to
114665d
Compare
graphite-app
bot
force-pushed
the
11-30-test_lsp_add_tests_for_removing_folders_in_workspace_didchangeworkspacefolders_notification
branch
from
9c90815 to
1d3994d
Compare
graphite-app
bot
force-pushed
the
11-30-test_lsp_add_tests_for_removing_folders_in_workspace_didchangeworkspacefolders_notification
branch
from
1d3994d to
64b59d9
Compare
Sysix
force-pushed
the
11-30-test_lsp_add_tests_for_removing_folders_in_workspace_didchangeworkspacefolders_notification
branch
from
64b59d9 to
3eaddb8
Compare
Member
Author
Merge activity
|
…spaceFolders` notification (#16308)
graphite-app
bot
force-pushed
the
11-30-test_lsp_add_tests_for_removing_folders_in_workspace_didchangeworkspacefolders_notification
branch
from
3eaddb8 to
5ffc042
Compare
graphite-app
bot
deleted the
11-30-test_lsp_add_tests_for_removing_folders_in_workspace_didchangeworkspacefolders_notification
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…spaceFolders` notification (oxc-project#16308)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.