Skip to content

fix(linter/plugins): fix message interpolation #16300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 30, 2025
Merged

fix(linter/plugins): fix message interpolation #16300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/oxlint/src-js/plugins/report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ interface DiagnosticReport {
// Diagnostics array. Reused for every file.
export const diagnostics: DiagnosticReport[] = [];

// Regex for message placeholders.
// https://github.com/eslint/eslint/blob/772c9ee9b65b6ad0be3e46462a7f93c37578cfa8/lib/linter/interpolate.js#L16-L18
const PLACEHOLDER_REGEX = /\{\{([^{}]+)\}\}/gu;

/**
* Report error.
* @param diagnostic - Diagnostic object
Expand All @@ -78,10 +82,12 @@ export function report(diagnostic: Diagnostic, ruleDetails: RuleDetails): void {
if (hasOwn(diagnostic, "data")) {
const { data } = diagnostic;
if (data != null) {
message = message.replace(/\{\{([^}]+)\}\}/g, (match, key) => {
message = message.replace(PLACEHOLDER_REGEX, (match, key) => {
key = key.trim();
const value = data[key];
return value !== undefined ? String(value) : match;
// TS type def for `string.replace` callback is `(substring: string, ...args: any[]) => string`,
// but actually returning other types e.g. `number` or `boolean` is fine
return value !== undefined ? (value as string) : match;
});
}
}
Expand Down
Loading