Skip to content

Comments

refactor(linter/plugins): add parse function#16240

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-28-refactor_linter_plugins_add_parse_function
Nov 30, 2025
Merged

refactor(linter/plugins): add parse function#16240
graphite-app[bot] merged 1 commit intomainfrom
11-28-refactor_linter_plugins_add_parse_function

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 28, 2025

Add function to parse source text into raw transfer buffer to apps/oxlint. It's required for rule tester (#16206).

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 28, 2025
Copy link
Member Author

overlookmotel commented Nov 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 28, 2025

CodSpeed Performance Report

Merging #16240 will not alter performance

Comparing 11-28-refactor_linter_plugins_add_parse_function (26e3bdd) with main (10a793e)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on 11-30-refactor_linter_plugins_store_messageid_in_diagnostics (72b48e7) during the generation of this report, so main (10a793e) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel force-pushed the 11-28-refactor_linter_plugins_add_parse_function branch 2 times, most recently from 6f782ba to b184e4f Compare November 28, 2025 15:43
@overlookmotel overlookmotel changed the base branch from main to graphite-base/16240 November 29, 2025 02:33
@overlookmotel overlookmotel force-pushed the 11-28-refactor_linter_plugins_add_parse_function branch from b184e4f to 1d22ec5 Compare November 29, 2025 02:33
@overlookmotel overlookmotel changed the base branch from graphite-base/16240 to 11-28-feat_linter_plugins_implement_sourcecode_getnodebyrangeindex_ November 29, 2025 02:33
@graphite-app graphite-app bot changed the base branch from 11-28-feat_linter_plugins_implement_sourcecode_getnodebyrangeindex_ to graphite-base/16240 November 29, 2025 02:43
@graphite-app graphite-app bot force-pushed the 11-28-refactor_linter_plugins_add_parse_function branch from 1d22ec5 to 43d7fef Compare November 29, 2025 02:49
@graphite-app graphite-app bot force-pushed the graphite-base/16240 branch from 2d68a5a to 7150209 Compare November 29, 2025 02:49
@graphite-app graphite-app bot changed the base branch from graphite-base/16240 to main November 29, 2025 02:49
@graphite-app graphite-app bot force-pushed the 11-28-refactor_linter_plugins_add_parse_function branch from 43d7fef to 96f4c5b Compare November 29, 2025 02:50
@overlookmotel overlookmotel force-pushed the 11-28-refactor_linter_plugins_add_parse_function branch from 96f4c5b to 4318041 Compare November 30, 2025 15:25
@overlookmotel overlookmotel changed the base branch from main to graphite-base/16240 November 30, 2025 16:22
@overlookmotel overlookmotel force-pushed the 11-28-refactor_linter_plugins_add_parse_function branch from 4318041 to eb44265 Compare November 30, 2025 16:22
@overlookmotel overlookmotel changed the base branch from graphite-base/16240 to 11-30-refactor_linter_plugins_store_messageid_in_diagnostics November 30, 2025 16:22
@overlookmotel overlookmotel self-assigned this Nov 30, 2025
@overlookmotel overlookmotel force-pushed the 11-28-refactor_linter_plugins_add_parse_function branch from eb44265 to fa5947d Compare November 30, 2025 19:00
@overlookmotel overlookmotel force-pushed the 11-30-refactor_linter_plugins_store_messageid_in_diagnostics branch from 65cd570 to c56d44d Compare November 30, 2025 19:00
@overlookmotel overlookmotel force-pushed the 11-28-refactor_linter_plugins_add_parse_function branch from fa5947d to 26e3bdd Compare November 30, 2025 23:16
@overlookmotel overlookmotel force-pushed the 11-30-refactor_linter_plugins_store_messageid_in_diagnostics branch from c56d44d to 72b48e7 Compare November 30, 2025 23:16
@overlookmotel overlookmotel marked this pull request as ready for review November 30, 2025 23:18
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 30, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 30, 2025

Merge activity

Add function to parse source text into raw transfer buffer to `apps/oxlint`. It's required for rule tester (#16206).
@graphite-app graphite-app bot force-pushed the 11-30-refactor_linter_plugins_store_messageid_in_diagnostics branch from 72b48e7 to 1af1091 Compare November 30, 2025 23:51
@graphite-app graphite-app bot force-pushed the 11-28-refactor_linter_plugins_add_parse_function branch from 26e3bdd to db2afba Compare November 30, 2025 23:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 30, 2025
Base automatically changed from 11-30-refactor_linter_plugins_store_messageid_in_diagnostics to main November 30, 2025 23:57
@graphite-app graphite-app bot merged commit db2afba into main Nov 30, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 11-28-refactor_linter_plugins_add_parse_function branch November 30, 2025 23:57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this code the same as oxc parser napi package? should the code between the two be shared?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mostly the same, but has some differences to integrate with the slight difference between oxc-parser and oxlint (Oxlint doesn't deal with the module record).

Is there a way to have code shared between the 2 packages, without a dependency? Maybe if we convert napi/parser to TS, and build it with TSDown. (speaking of converting, yes, I'm a convert to TS)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to have code shared between the 2 packages, without a dependency?

best way it just to have it as a dep, we can make sure that tsdown bundles it so there'll be no runtime overhead

taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Add function to parse source text into raw transfer buffer to `apps/oxlint`. It's required for rule tester (oxc-project#16206).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants