refactor(linter/plugins): add registerPlugin function#16210
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 27, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the plugin loading logic by extracting the synchronous plugin registration logic from the async loadPluginImpl function into a new registerPlugin function. This separation prepares the codebase for #16206, which will need to register plugins directly without importing them from a module.
Key changes:
- Renamed
loadPluginImpltoregisterPluginand made it synchronous - Moved plugin import and duplicate registration check into
loadPlugin - Updated JSDoc comments to reflect the new function signature
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
from
1302f61 to
afc5df6
Compare
overlookmotel
changed the base branch from
graphite-base/16210
to
11-27-doc_linter_plugins_fix_jsdoc_comment_for_loadplugin_
overlookmotel
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
from
afc5df6 to
df85032
Compare
overlookmotel
force-pushed
the
11-27-doc_linter_plugins_fix_jsdoc_comment_for_loadplugin_
branch
2 times, most recently
from
9f3caf6 to
c3526d7
Compare
overlookmotel
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
from
df85032 to
54de704
Compare
graphite-app
bot
changed the base branch from
11-27-doc_linter_plugins_fix_jsdoc_comment_for_loadplugin_
to
graphite-base/16210
graphite-app
bot
force-pushed
the
graphite-base/16210
branch
from
c3526d7 to
be36e36
Compare
graphite-app
bot
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
from
54de704 to
be3b9ee
Compare
graphite-app
bot
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
from
be3b9ee to
832983a
Compare
overlookmotel
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
2 times, most recently
from
b15c057 to
35ce097
Compare
This was referenced Nov 27, 2025
Contributor
Merge activity
|
Pure refactor. Move a few lines of code into `loadPlugin`, to leave a sync function `registerPlugin` which contains the logic for registering a plugin. Required for #16206, which will call this method directly, skipping `import`-ing the plugin from a module.
graphite-app
bot
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
from
35ce097 to
c6245a4
Compare
graphite-app
bot
deleted the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…16210) Pure refactor. Move a few lines of code into `loadPlugin`, to leave a sync function `registerPlugin` which contains the logic for registering a plugin. Required for oxc-project#16206, which will call this method directly, skipping `import`-ing the plugin from a module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Move a few lines of code into
loadPlugin, to leave a sync functionregisterPluginwhich contains the logic for registering a plugin.Required for #16206, which will call this method directly, skipping
import-ing the plugin from a module.