Skip to content

fix(formatter/sort_imports): Handle internal prefixes correctly #16128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 26, 2025
Merged

fix(formatter/sort_imports): Handle internal prefixes correctly #16128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_formatter/src/ir_transform/sort_imports/compute_metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ fn to_path_kind(source: &str) -> ImportPathKind {
}

// TODO: This can be changed via `options.internalPattern`
if source.starts_with('~') || source.starts_with('@') {
if source.starts_with("~/") || source.starts_with("@/") {
return ImportPathKind::Internal;
}

Expand Down
16 changes: 16 additions & 0 deletions crates/oxc_formatter/tests/ir_transform/sort_imports.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,22 @@ import("a");
import b from "b";
import c from "c";
import("a");
"#,
);
assert_format(
r#"
import internal from "~/internal";
import internal2 from "@/internal2";
import external from "external";
import external2 from "@external2";
"#,
r#"{ "experimentalSortImports": {} }"#,
r#"
import external2 from "@external2";
import external from "external";

import internal2 from "@/internal2";
import internal from "~/internal";
"#,
);
}
Expand Down
Loading