Skip to content

Comments

test(linter/plugins): use subpath imports in tests#16075

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-24-test_linter_plugins_use_subpath_imports_in_tests
Nov 24, 2025
Merged

test(linter/plugins): use subpath imports in tests#16075
graphite-app[bot] merged 1 commit intomainfrom
11-24-test_linter_plugins_use_subpath_imports_in_tests

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 24, 2025

#15920 altered imports in tests to use '#eslint' subpath. Make recently-added tests follow the same pattern.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Nov 24, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Nov 24, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 24, 2025 19:37
Copilot AI review requested due to automatic review settings November 24, 2025 19:37
@overlookmotel overlookmotel self-assigned this Nov 24, 2025
@overlookmotel overlookmotel added A-linter-plugins Area - Linter JS plugins 0-merge Merge with Graphite Merge Queue labels Nov 24, 2025
Copy link
Member Author

overlookmotel commented Nov 24, 2025

Merge activity

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates import statements in two recently-added test fixture files to use the #oxlint subpath import instead of relative paths (../../../dist/index.js), aligning with the convention established in PR #15920.

  • Standardizes import patterns across all oxlint test fixtures
  • Improves maintainability by using package.json-defined subpath imports

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/oxlint/test/fixtures/tokens/plugin.ts Updated import to use #oxlint subpath instead of relative path
apps/oxlint/test/fixtures/sourceCode_token_methods/plugin.ts Updated import to use #oxlint subpath instead of relative path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

#15920 altered `import`s in tests to use `'#eslint'` subpath. Make recently-added tests follow the same pattern.
@graphite-app graphite-app bot force-pushed the 11-24-test_linter_plugins_use_subpath_imports_in_tests branch from 7ed55e3 to 791d632 Compare November 24, 2025 19:48
@graphite-app graphite-app bot merged commit 791d632 into main Nov 24, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-24-test_linter_plugins_use_subpath_imports_in_tests branch November 24, 2025 19:53
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
oxc-project#15920 altered `import`s in tests to use `'#eslint'` subpath. Make recently-added tests follow the same pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant