Skip to content

chore(vscode): introduce oxc.path.oxlint and deprecate oxc.path.server#16072

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-24-chore_vscode_introduce_oxc.path.oxlint_and_deprecate_oxc.path.server_
Nov 25, 2025
Merged

chore(vscode): introduce oxc.path.oxlint and deprecate oxc.path.server#16072
graphite-app[bot] merged 1 commit intomainfrom
11-24-chore_vscode_introduce_oxc.path.oxlint_and_deprecate_oxc.path.server_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Nov 24, 2025

Preparing to remove the language server binary, renaming the setting.

related #15740

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 24, 2025
Copy link
Member Author

Sysix commented Nov 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new configuration option oxc.path.oxlint to replace the deprecated oxc.path.server, aligning the naming to reflect that the extension now uses the oxlint binary instead of a separate language server binary. The deprecated setting is maintained for backward compatibility with appropriate deprecation warnings.

Key changes:

  • Added new oxc.path.oxlint configuration setting with deprecation of oxc.path.server
  • Renamed internal property from binPath to binPathOxlint throughout the codebase
  • Added fallback logic to respect the deprecated setting when the new one is not set

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
editors/vscode/package.json Added oxc.path.oxlint configuration and marked oxc.path.server as deprecated with migration guidance
editors/vscode/client/VSCodeConfig.ts Renamed property to binPathOxlint and implemented fallback logic for deprecated setting
editors/vscode/client/ConfigService.ts Updated to use renamed binPathOxlint property
editors/vscode/tests/VSCodeConfig.spec.ts Updated tests to cover new property name and added test for deprecated setting support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sysix Sysix force-pushed the 11-24-chore_vscode_introduce_oxc.path.oxlint_and_deprecate_oxc.path.server_ branch from 444b911 to 20c1123 Compare November 25, 2025 00:06
@Sysix Sysix marked this pull request as ready for review November 25, 2025 00:23
@Sysix Sysix requested a review from camc314 as a code owner November 25, 2025 00:23
@Sysix Sysix force-pushed the 11-24-chore_vscode_introduce_oxc.path.oxlint_and_deprecate_oxc.path.server_ branch from 20c1123 to 0e636f0 Compare November 25, 2025 01:04
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 25, 2025
Copy link
Contributor

camc314 commented Nov 25, 2025

Merge activity

  • Nov 25, 9:02 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 25, 9:02 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Nov 25, 9:02 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 25, 9:59 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Nov 25, 10:01 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Nov 25, 11:14 AM UTC: Sysix added this pull request to the Graphite merge queue.
  • Nov 25, 11:19 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 25, 2025
@Sysix Sysix force-pushed the 11-24-chore_vscode_introduce_oxc.path.oxlint_and_deprecate_oxc.path.server_ branch from 0e636f0 to 5ccbd9e Compare November 25, 2025 11:04
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 25, 2025
…rver` (#16072)

Preparing to remove the language server binary, renaming the setting.

related #15740
@graphite-app graphite-app bot force-pushed the 11-24-chore_vscode_introduce_oxc.path.oxlint_and_deprecate_oxc.path.server_ branch from 5ccbd9e to 4d56147 Compare November 25, 2025 11:14
@graphite-app graphite-app bot merged commit 4d56147 into main Nov 25, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 11-24-chore_vscode_introduce_oxc.path.oxlint_and_deprecate_oxc.path.server_ branch November 25, 2025 11:19
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 25, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
…rver` (oxc-project#16072)

Preparing to remove the language server binary, renaming the setting.

related oxc-project#15740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants