Skip to content

perf(linter/plugins): recycle objects in token methods #16068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 24, 2025
Merged

perf(linter/plugins): recycle objects in token methods #16068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions apps/oxlint/src-js/plugins/tokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ export interface TemplateToken extends BaseToken {
type: 'Template';
}

// `SkipOptions` object used by `getTokenOrCommentBefore` and `getTokenOrCommentAfter`.
// This object is reused over and over to avoid creating a new options object on each call.
const INCLUDE_COMMENTS_SKIP_OPTIONS: SkipOptions = { includeComments: true, skip: 0 };

// Tokens for the current file parsed by TS-ESLint.
// Created lazily only when needed.
export let tokens: Token[] | null = null;
Expand Down Expand Up @@ -803,7 +807,10 @@ export function getTokenBefore(
* @returns `Token`, or `null` if all were skipped.
*/
export function getTokenOrCommentBefore(nodeOrToken: NodeOrToken | Comment, skip?: number): Token | null {
return getTokenBefore(nodeOrToken, { includeComments: true, skip });
// Equivalent to `return getTokenBefore(nodeOrToken, { includeComments: true, skip });`,
// but reuse a global object to avoid creating a new object on each call
INCLUDE_COMMENTS_SKIP_OPTIONS.skip = skip;
return getTokenBefore(nodeOrToken, INCLUDE_COMMENTS_SKIP_OPTIONS);
}

/**
Expand Down Expand Up @@ -1002,7 +1009,10 @@ export function getTokenAfter(
* @returns `Token`, or `null` if all were skipped.
*/
export function getTokenOrCommentAfter(nodeOrToken: NodeOrToken | Comment, skip?: number): Token | null {
return getTokenAfter(nodeOrToken, { includeComments: true, skip });
// Equivalent to `return getTokenAfter(nodeOrToken, { includeComments: true, skip });`,
// but reuse a global object to avoid creating a new object on each call
INCLUDE_COMMENTS_SKIP_OPTIONS.skip = skip;
return getTokenAfter(nodeOrToken, INCLUDE_COMMENTS_SKIP_OPTIONS);
}

/**
Expand Down
Loading