refactor(linter/plugins): reimplement isSpaceBetween() isSpaceBetweenTokens() using tokens#16055
Merged
overlookmotel merged 18 commits intooxc-project:mainfrom Nov 27, 2025
Merged
Conversation
github-actions
bot
added
A-linter
This was referenced Nov 24, 2025
lilnasy
force-pushed
the
isSpaceBetween
branch
4 times, most recently
from
5ceb6d8 to
598e16d
Compare
lilnasy
changed the title
isSpaceBetween using tokensisSpaceBetween() isSpaceBetweenTokens() using tokens
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the isSpaceBetween and isSpaceBetweenTokens functions to use a token-based implementation instead of checking whitespace in the source code directly. This fixes issues where the previous implementation incorrectly returned true for cases like x+" "+y where the whitespace is inside a string token, not between tokens.
Key changes:
- Reimplemented both functions to iterate through tokens and check for gaps between them using binary search
- Fixed incorrect behavior where whitespace inside tokens (like string literals or JSXText) was counted as space between nodes
- Removed outdated comments explaining known bugs that are now fixed
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/tokens.ts | Reimplemented isSpaceBetween() and isSpaceBetweenTokens() using token-based iteration with binary search; removed unused initSourceText import; added JSX_WHITESPACE_REGEXP constant |
| apps/oxlint/test/isSpaceBetween.test.ts | Added comprehensive test cases for isSpaceBetween() covering various whitespace scenarios and JSX edge cases |
| apps/oxlint/test/fixtures/isSpaceBetween/output.snap.md | Updated snapshots to reflect corrected behavior (false instead of true for string literals and JSX text with internal spaces) |
| apps/oxlint/test/fixtures/isSpaceBetween/files/index.js | Removed comment about known incorrect behavior that has been fixed |
| apps/oxlint/test/fixtures/isSpaceBetween/files/index.jsx | Removed comments about known incorrect behavior that has been fixed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lilnasy
force-pushed
the
isSpaceBetween
branch
from
49c79a3 to
654d719
Compare
If `tokensWithComments !== null`, no need to check if `tokens === null`.
Our convention for comments is: 1. Comment which is a single sentence = no full stop on end. 2. Comment which is multiple sentences = full stop on end of each sentence. 3. Comments preceding a top-level var, class, or type definition = full stop on end. Maybe that's too complicated, but IMO having *some* convention is more important than what that convention is exactly.
overlookmotel
force-pushed
the
isSpaceBetween
branch
from
654d719 to
bc1f7cc
Compare
overlookmotel
approved these changes
Nov 27, 2025
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
Excellent! Thanks very much for adding so many tests.
I've pushed a few commits - all nits. I've only split it into so many tiny commits so you can see what I'm trying to do clearly (if you're interested).
31 tasks
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…eenTokens()` using tokens (oxc-project#16055) - Follow up to oxc-project#15498 and oxc-project#15861 - Note: JSX special case (as part of the `isSpaceBetweenTokens()` method) is being removed in ESLint v10 (see [eslint/eslint#20137](https://github.com/eslint/eslint/pull/20137/files#diff-e85eaebdcf6af45c06572019cbd900cff91518c789049c3bd0e8724c18645ab0)) ### Tasks: - [x] Token-based reimplementation of `isSpaceBetween()` - [x] Token-based reimplementation of `isSpaceBetweenTokens()` - [x] Pass existing tests from oxc-project#15498 - [x] New tests for JS syntax - [x] New tests for JSX syntax --------- Co-authored-by: overlookmotel <theoverlookmotel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceCode#isSpaceBetween#15498 and feat(linter/plugins): Token-relatedSourceCodeAPIs (TS ESLint implementation) #15861isSpaceBetweenTokens()method) is being removed in ESLint v10 (see eslint/eslint#20137)Tasks:
isSpaceBetween()isSpaceBetweenTokens()SourceCode#isSpaceBetween#15498