ci(lint): enable no-console rule#16053
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 24, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enforces the no-console linting rule across the codebase to prevent accidental console statements in production code, while explicitly allowing console usage in build scripts and utilities through oxlint disable comments.
Key Changes:
- Enable
no-consolerule inoxlintrc.jsonas an error-level rule - Add file-level
oxlint-disablecomments to script files that use console throughout (main.mjs, build scripts, GitHub Actions scripts) - Add line-level disable comments for specific console statements in generated/utility scripts
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| oxlintrc.json | Adds no-console: error rule to enforce no console usage in production code |
| tasks/transform_conformance/reporter.mjs | File-level disable for test reporter that logs test results |
| tasks/lint_rules/src/oxlint-rules.mjs | Line-level disable for diagnostic logging when rule not found |
| tasks/lint_rules/src/main.mjs | File-level disable for CLI script that outputs to console |
| npm/oxlint/scripts/generate-packages.js | File-level disable for build script that logs generation progress |
| npm/oxfmt/scripts/generate-packages.js | File-level disable for build script that logs generation progress |
| napi/parser/scripts/visitor-keys.js | Line-level disable for script output |
| napi/parser/example.js | Line-level disable added to existing disable comment |
| crates/oxc_traverse/scripts/build.mjs | Line-level disable for build progress logging |
| apps/oxlint/scripts/build.ts | File-level disable for build script that logs build steps |
| apps/oxfmt/scripts/build.js | File-level disable for build script that logs build steps |
| .github/scripts/utils.js | File-level disable for GitHub Actions utility functions |
| .github/scripts/get-changed-files.js | File-level disable for GitHub Actions script |
| .github/scripts/generate-benchmark-matrix.js | File-level disable for GitHub Actions script |
| .github/scripts/check-conformance-changes.js | File-level disable for GitHub Actions script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
approved these changes
Nov 24, 2025
Contributor
Merge activity
|
Enable `no-console` rule in our linting setup. Add `oxlint-disable` comments where we do want to log (in scripts).
graphite-app
bot
force-pushed
the
11-24-ci_lint_enable_no-console_rule
branch
from
3b33da5 to
5877752
Compare
overlookmotel
added a commit
that referenced
this pull request
Nov 24, 2025
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
Enable `no-console` rule in our linting setup. Add `oxlint-disable` comments where we do want to log (in scripts).
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…6015) After oxc-project#16013, oxc-project#16014, and oxc-project#16053, we can now enable checking for unused `oxlint-disable` comments in our linting setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
no-consolerule in our linting setup. Addoxlint-disablecomments where we do want to log (in scripts).