test(linter/plugins): cases for SourceCode#getLastToken() and SourceCode#getLastToken()#16048
Merged
overlookmotel merged 1 commit intooxc-project:mainfrom Nov 24, 2025
Conversation
feb1b2b to
dc0e224
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for SourceCode#getLastToken() and SourceCode#getTokenBefore() methods in the linter plugin system, based on ESLint's v9.39.1 test suite. The tests verify that these methods correctly traverse tokens and comments in reverse order.
- Implements two test cases that verify token traversal with and without spaces
- Tests the combination of
getLastToken()to get the final token andgetTokenBefore()to traverse backwards through all tokens and comments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
approved these changes
Nov 24, 2025
dc0e224 to
124d05b
Compare
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…ceCode#getLastToken()` (oxc-project#16048) - Part of oxc-project#14829 (comment). - Follow up to oxc-project#15861.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceCodeAPIs #14829 (comment).SourceCodeAPIs (TS ESLint implementation) #15861.