refactor(formatter): replace format_once with format_with where possible

[Dunqing]

format_once has slightly overhead as its T was wrapped by Cell to avoid double calling. So prefer to format_with when possible

[Dunqing]

• fix(formatter): handle poor layout for grouped call arguments #16093
• refactor(formatter): make Format::fmt non-failable #16036
• refactor(formatter): adjust implementations of Function and ArrowFunctionExpression #16035
• refactor(formatter): replace format_once with format_with where possible #16031 👈 (View in Graphite)
• fix(formatter): revert FormatElement::BestFitting printing logic #16028
• fix(formatter): incorrect formatting method chain with trailing comments #16027
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #16031 will not alter performance

_{Comparing 11-24-refactor_formatter_replace_format_once_with_format_with_where_possible (c76ff3c) with 11-24-fix_formatter_revert_bestfitting_printing_logic (74d7dc8)}

Summary

✅ 38 untouched
⏩ 7 skipped¹

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Dunqing]

I am going to merge these three PRs without @leaysgur's review since you are not available today. I've confirmed there's no regression in the VSCode repo. Feel free to review after you come back.

[Dunqing]

Merge activity

• Nov 24, 9:00 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Nov 24, 9:00 AM UTC: Dunqing added this pull request to the Graphite merge queue.
• Nov 24, 9:08 AM UTC: Merged by the Graphite merge queue.