Skip to content

Comments

style(linter/plugins): subtract 1 -> decrement operator#16029

Merged
overlookmotel merged 2 commits intooxc-project:mainfrom
lilnasy:subtraction-decrement
Nov 24, 2025
Merged

style(linter/plugins): subtract 1 -> decrement operator#16029
overlookmotel merged 2 commits intooxc-project:mainfrom
lilnasy:subtraction-decrement

Conversation

@lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Nov 24, 2025

@lilnasy lilnasy requested a review from camc314 as a code owner November 24, 2025 05:48
Copilot AI review requested due to automatic review settings November 24, 2025 05:48
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies a stylistic consistency change to use the decrement operator (--) instead of the compound assignment operator (-= 1) in the tokens module. The changes align with the existing coding style used throughout the TypeScript codebase.

  • All instances of -= 1 are replaced with -- for consistency
  • No functional changes are introduced—the operations remain semantically identical
  • The changes improve code brevity and consistency with the rest of the codebase

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lilnasy lilnasy force-pushed the subtraction-decrement branch from f408121 to de91e0b Compare November 24, 2025 10:58
@overlookmotel overlookmotel self-requested a review as a code owner November 24, 2025 16:38
@overlookmotel overlookmotel self-assigned this Nov 24, 2025
@overlookmotel overlookmotel merged commit c52f234 into oxc-project:main Nov 24, 2025
17 checks passed
@lilnasy lilnasy deleted the subtraction-decrement branch November 24, 2025 17:46
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
…16029)

- Trying to get the simpler stylistic and consistency edits out of the
way.
- Originally added in oxc-project#16002 and
oxc-project#15956.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants