Skip to content

test(linter/plugins): remove unnecessary lint disable comment#16006

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-23-test_linter_plugins_remove_unnecessary_lint_disable_comment
Nov 23, 2025
Merged

test(linter/plugins): remove unnecessary lint disable comment#16006
graphite-app[bot] merged 1 commit intomainfrom
11-23-test_linter_plugins_remove_unnecessary_lint_disable_comment

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 23, 2025 •
edited
Loading

Not sure why oxlint didn't flag that this oxlint-disable-next-line comment is unnecessary, but it is. Remove it.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Nov 23, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Nov 23, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 23, 2025 20:40
Copilot AI review requested due to automatic review settings November 23, 2025 20:40
@overlookmotel overlookmotel self-assigned this Nov 23, 2025
@overlookmotel overlookmotel added the A-linter-plugins Area - Linter JS plugins label Nov 23, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 23, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 23, 2025 •
edited by graphite-app bot
Loading

Merge activity

Copilot AI reviewed Nov 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unnecessary oxlint-disable-next-line no-unused-vars comment that was incorrectly flagging the VariableDeclaratorIdentifier variable as unused, when in fact it is used extensively throughout the test file (20+ references).

Key Changes

  • Removed an incorrect lint disable comment for a variable that is actually used in the test suite

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel
test(linter/plugins): remove unnecessary lint disable comment (#16006)
a13634d 
Not sure why oxlint didn't flag that this `oxlint-disable-next-line` comment is unnecessary, but it is. Remove it.
@graphite-app graphite-app bot force-pushed the 11-23-test_linter_plugins_remove_unnecessary_lint_disable_comment branch from 37303d5 to a13634d Compare November 23, 2025 20:45
@graphite-app graphite-app bot merged commit a13634d into main Nov 23, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-23-test_linter_plugins_remove_unnecessary_lint_disable_comment branch November 23, 2025 20:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 23, 2025
@Sysix
Copy link
Member

Sysix commented Nov 23, 2025

Not sure why oxlint didn't flag that

https://oxc.rs/docs/guide/usage/linter/cli.html#inline-configuration-comments
--report-unused-disable-directives(-serverity) is missing

@overlookmotel
Copy link
Member Author

overlookmotel commented Nov 23, 2025

Thanks @Sysix. Now enabled that option in #16015 (and fixed what it found).

taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@overlookmotel @taearls
test(linter/plugins): remove unnecessary lint disable comment (oxc-pr…
e822d76 
…oject#16006)

Not sure why oxlint didn't flag that this `oxlint-disable-next-line` comment is unnecessary, but it is. Remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @Sysix